[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Another gcj (boehm-gc?) related FTBFS for y’all to look at



Hi Doko,

can we have a patch in the next gcj please (not urgent, but
surely nice to have in general)?


Dixi quod…

>Andreas Schwab dixit:
>
>>>>> Sem_wait returned -1
>>>>> sem_wait for handler failed

>>It doesn't say what was the error.

>gcc-4.4-4.4.5/src/boehm-gc/pthread_stop_world.c
>
>  428     for (i = 0; i < n_live_threads; i++) {
>  429           while (0 != (code = sem_wait(&GC_suspend_ack_sem))) {
>  430               if (errno != EINTR) {
>  431                  GC_err_printf1("Sem_wait returned %ld\n", (unsigned long)code);
>  432                  ABORT("sem_wait for handler failed");

Something like this (feel free to DWYW):

		if (errno != EINTR) {
+		  int e = errno;
-		  GC_err_printf1("Sem_wait returned %ld\n", (unsigned long)code);
+		  GC_err_printf1("Sem_wait returned %ld (%d)\n", (unsigned long)code, e);


@Andreas: thanks, I’ll try your patch.

Thanks in advance,
//mirabilos
-- 
I believe no one can invent an algorithm. One just happens to hit upon it
when God enlightens him. Or only God invents algorithms, we merely copy them.
If you don't believe in God, just consider God as Nature if you won't deny
existence.		-- Coywolf Qi Hunt


Reply to: