[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: toolchain problems



Well the version number is cvs20080103-4, which makes me think it's not
recent enough for the patch to already be there. I would think the patch
itself would just work, but I haven't built and tested it (yet).

Are you working on it, or should I give it a go?

Please give it a go. I'm still working on classifying bugs and tracking
some other low hanging fruit.

Well, if shoehorning a three line patch of Roman's into our binutils isn't low hanging ...

I looked at the source and the only piece of the patch that'll need tweaking is the changelog bit. Built fine, binaries are on http://people.debian.org/~schmitz/m68k/, please test!

James, Doko: This is the patch I'm currently testing, relative to binutils-2.18.1~cvs20080103. It built ok on hobbes overnight.

According to Joseph Myers <joseph@codesourcery.com>, the patch will fix a number of m68k build errors related to nonrepresentable sections when using -fpie on m68k. The patch is included in binutils CVS since 2008-03-06. See Stephen's bug of the day #478583 ...

Do you want to incorporate this in a future release, or will a NMU be accepted?

Cheers,

	Michael

--- /dev/null	2005-09-14 18:32:30.000000000 +0200
+++ debian/patches/309_m68k-pie.dpatch	2008-04-30 03:42:02.000000000 +0200
@@ -0,0 +1,53 @@
+#!/bin/sh -e
+## 309_m68k-pie.dpatch
+##
+## DP: Description: Enable generation of PIE ld script on m68k
+## DP: Upstream status: merged in recent upstream CVS
+
+if [ $# -ne 1 ]; then
+    echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
+    exit 1
+fi
+
+[ -f debian/patches/00patch-opts ] && . debian/patches/00patch-opts
+patch_opts="${patch_opts:--f --no-backup-if-mismatch}"
+
+case "$1" in
+       -patch) patch $patch_opts -p0 < $0;;
+       -unpatch) patch $patch_opts -p0 -R < $0;;
+        *)
+                echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
+                exit 1;;
+esac
+
+exit 0
+
+@DPATCH@
+--- ld/ChangeLog	2008/02/22 14:19:42	1.1804
++++ ld/ChangeLog	2008/03/06 12:29:52	1.1805
+@@ -1,3 +1,9 @@
++2008-03-06  Joseph Myers  <joseph@codesourcery.com>
++	    Roman Zippel  <zippel@linux-m68k.org>
++
++	* emulparams/m68kelf.sh (GENERATE_PIE_SCRIPT): Define.
++	(COMMONPAGESIZE): Define.
++
+ 2007-08-28  Robert Sebastian Gerus  <arachnist@gmail.com>
+ + * configure.host: Add support for i[3-7]86-*-dragonfly*.
+--- ld/emulparams/m68kelf.sh	2007/08/09 11:02:24	1.6
++++ ld/emulparams/m68kelf.sh	2008/03/06 12:29:52	1.7
+@@ -2,10 +2,12 @@
+ OUTPUT_FORMAT="elf32-m68k"
+ TEXT_START_ADDR=0x80000000
+ MAXPAGESIZE="CONSTANT (MAXPAGESIZE)"
++COMMONPAGESIZE="CONSTANT (COMMONPAGESIZE)"
+ ARCH=m68k
+ MACHINE=
+ NOP=0x4e754e75
+ TEMPLATE_NAME=elf32
+ EXTRA_EM_FILE=m68kelf
+ GENERATE_SHLIB_SCRIPT=yes
+-NO_SMALL_DATA=yes
++GENERATE_PIE_SCRIPT=yes
++NO_SMALL_DATA=yes
--- debian/patches/00list~	2008-04-30 03:21:11.000000000 +0200
+++ debian/patches/00list	2008-04-30 03:21:11.000000000 +0200
@@ -9,3 +9,4 @@
 306_pr4453
 307_ld-pic
 308_mips-pic
+309_m68k-pie


Reply to: