[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Sarge/testing crashes on Mac Quadra 650



On Tue, 31 Aug 2004, Erik C.J. Laan wrote:
> Finn Thain wrote:
> > On Tue, 31 Aug 2004, Erik C.J. Laan wrote:
> >>I've installed Sarge/testing on my Mac Quadra 650 succesfully with
> >>Debian Installer RC1. Now I want to start using it to test (mac-fdisk
> >>amongst others), but it crashes sometimes. These crashes seem to only
> >>happen when I SSH into the machine. It does not matter whether I SSH
> >>into it with PuTTY (0.52 and 0.55) or the Woody SSH client (with
> >>security updates). First with the 2.2.25-mac kernel installed by D-I
> >>only the network-connection was dropped, with no messages printed
> >>anywere (console or serial debug output). With the 2.2.25 kernel from
> >>the 2.2.25-2 deb it really crashes, but a message is printed:
> >>
> >>Warning: kfree-skb passed an skb still on a list (from xxxxx)
> >>
> >>This happen 2 times, the first time xxxxx was 000e4416, the second time
> >>it was 000d3136.
> >
> >
> > I gather you are using the Q650 onboard ethernet? I've been digging in
> > the sonic code in the various repositories lately, and I ran accross this
> > change. It could be relevant, I don't know.
> >
> > --- linux/drivers/net/sonic.c	2003/06/08 08:08:49	1.1.1.1.2.2
> > +++ linux/drivers/net/sonic.c	2003/07/21 21:11:35	1.1.1.1.2.3
> > @@ -223,7 +223,7 @@ static void sonic_interrupt(int irq, voi
> >
> >  			/* We must free the original skb */
> >  			if (lp->tx_skb[entry]) {
> > -				dev_kfree_skb(lp->tx_skb[entry]);
> > +				dev_kfree_skb_irq(lp->tx_skb[entry]);
> >  				lp->tx_skb[entry] = 0;
> >  			}
> >  			/* and the VDMA address */
> >
> > This change was committed to the m68k-2_4 branch. It doesn't appear in any
> > other m68k nor mac68k branches, nor debian 2.2.25 code. Perhaps it should?
> > Can anyone comment on whether this patch is more widely useful?
>
> I can only confirm I'm using the onboard Sonic. I hope someone with
> knowledge of the ethernet driver can indeed tell us wheter this change
> should be in debian's 2.2.25 code too, and maybe even in 2.6.x?
> Forwarded this to the Linux/mac68k list too.

Here's the corresponding patch, as sent to Marcelo:

    http://linux-m68k-cvs.ubb.ca/~geert/linux-m68k-2.4.x-merging/integrated-2.4.23-pre2/098-sonic.diff

Should I apply it to 2.6.x as well? Anyone who can test?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



Reply to: