[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ccompiler failure on 2.4.24

The attached patch will also fix this compilation issue.

Looking at the CVS history of include/asm-m68k/keyboard.h, it looks like
Ray Knight added these macro definitions in revision, then
Geert Uytterhoeven removed them in revision

I don't understand why they were removed, though, since they are defined
in keyboard.h in every other arch.


The reason pc_keyb.c is compiled for CONFIG_MAC is that the mac m68k
port was changed to use the input core (CONFIG_INPUT) by Joshua Thompson
in October 2000.


On Mon, Feb 02, 2004 at 05:32:44PM +0100, Geert Uytterhoeven wrote:
> On Mon, 2 Feb 2004, Geert Uytterhoeven wrote:
> > On Mon, 2 Feb 2004, Hank wrote:
> > > My Quadra 840AV Running Debian 3.0_r2 failed to compile 2.4.24. Came
> > > pretty close though. Here's the stdout and stderr messages
> > > attached
> >
> > So I guess it compiled drivers/char/pc_keyb.c? Can you please post your
> > .config?
> Please try the patch below. It allowed me to compile a kernel using your
> .config.

Index: include/asm-m68k/keyboard.h
RCS file: /home/linux-m68k/cvsroot/linux/include/asm-m68k/Attic/keyboard.h,v
retrieving revision
retrieving revision
diff -u -u -r1.1.1.1 -r1.
--- include/asm-m68k/keyboard.h	21 Oct 2001 23:50:47 -0000
+++ include/asm-m68k/keyboard.h	25 Aug 2002 02:03:09 -0000
@@ -65,6 +65,11 @@
 #define kbd_request_region()
 #define kbd_request_irq(handler)
+/* How to access the keyboard macros on this platform.  */
+#define kbd_read_input() in_8(KBD_DATA_REG)
+#define kbd_read_status() in_8(KBD_STATUS_REG)
+#define kbd_write_output(val) out_8(KBD_DATA_REG, val)
+#define kbd_write_command(val) out_8(KBD_CNTL_REG, val)
 extern unsigned int SYSRQ_KEY;
 #endif /* __KERNEL__ */

Reply to: