On Sun, 2008-03-02 at 08:45 +0100, Petter Reinholdtsen wrote: > Hi. Here is a new small patch to dvswitch, adding a quit button to > the GUI. It will make it more obvious for the casual user to know how > to exit the program. Please include in a future version of dvswitch. The window manager should provide a close button; DVswitch does not need its own Quit button. At some point it will probably need a menu bar, at which point we can add a Quit menu item. If you think it's that important, add that. > Index: src/mixer_window.cpp > =================================================================== > --- src/mixer_window.cpp (revision 153) > +++ src/mixer_window.cpp (working copy) > @@ -46,6 +48,9 @@ > cut_button_.signal_pressed().connect(sigc::mem_fun(mixer_, &mixer::cut)); > cut_button_.show(); > > + quit_button_.signal_pressed().connect(sigc::mem_fun(*this, &mixer_window::quit)); > + quit_button_.show(); > + Use a call like sigc::ptr_fun(&Gtk::Main::quit) to bind free functions rather than inventing member functions. > display_.show(); > > selector_.set_accel_group(get_accel_group()); > @@ -58,6 +63,7 @@ > command_box_.set_spacing(gui_standard_spacing); > command_box_.pack_start(record_button_, Gtk::PACK_SHRINK); > command_box_.pack_start(cut_button_, Gtk::PACK_SHRINK); > + command_box_.pack_start(quit_button_, Gtk::PACK_SHRINK); This is just inviting people to quit by accident. The Quit button will be placed right next to the editing buttons. If the mnemonic is Q then it will be easy to quit if you miss the 1 key. (This is why I made the current keystroke Ctrl-Q whereas the more commonly needed commands require a single key.) I've added you to the Alioth project so you can commit changes directly. Please continue to discuss changes here before making them. Also you should be able to add larger things to the To Do list before starting on them. Ben. -- Ben Hutchings This sentence contradicts itself - no actually it doesn't.
Attachment:
signature.asc
Description: This is a digitally signed message part