[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Debconf-team] Penta save button fix

On Tue, Jun 21, 2011 at 01:49:10AM +0100, Moray Allan wrote:
> On Tue, Jun 21, 2011 at 12:44 AM, Moray Allan <moray@sermisy.org> wrote:
> > window.addEventListener('load', function() {
> >  new Form.Observer('content_form', 1, function(element, value ) {
> >               enable_save_button() } );
> > }, false);
> Richard has tried this on pentatest, and it seems to work with the
> desired behaviour -- i.e. no save button initially (as before), but it
> appears when you start editing a text field (new behaviour), as well
> as when you click a button (as before).

I modified all the other files gwolf found [1] on pentatest for our
currently working scheme: it has both the old method (detect when
input focus leaves a field that has just been edited) and also one
that polls every 2 seconds for any changes, enabling the save button
if there have been.

It should be live on pentatest for people to check in various browsers
- so far we have done iceweasel and chrome.  Main things to check are
is: a) does the save button not appear instantly?  b) if you edit a
text field, does the save button appear _before_ you click somewhere

It is uncommitted on pentatest for someone to check, commit, and move
over to production.

- richard

[1] http://paste.debian.net/120496/

| Richard Darst  -  rkd@          -  boltzmann: up 700 days, 3:37
|            http://rkd.zgib.net  -  pgp 0xBD356740
| "Ye shall know the truth and -- the truth shall make you free"

Reply to: