[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Mesa 6.4.2 and 6.5, Release Candidates



For the most part, your release candidates look good, and I'm pleased
to report that they build without errors on my amd64 box.  However, I
found the autogenerated mesa-swx11-source.install files to be a bit
off.  The main problem is one of formatting: dh_install always
interprets destination paths as *directories*, so repeating filenames
backfires badly, yielding unusable binary packages.  In addition, the
new approach seems to be major overkill -- whereas 6.4.1-0.4 shipped
349 files totalling ~7.6M, 6.4.2-1 ships 1060 files totalling ~18.3M.

I would suggest either maintaining the .install file directly, but
with wildcarded source paths (cutting the contents down to a
reasonable 31 lines by my count) or else fixing the logic as follows:

diff -u mesa-6.4.2/debian/rules mesa-6.4.2/debian/rules
--- mesa-6.4.2/debian/rules
+++ mesa-6.4.2/debian/rules
@@ -225,7 +225,8 @@
 debian/mesa-swx11-source.install:
 	( find src/mesa src/glx/x11 include/GL/internal -name '*.[ch]' ; \
 	  find include/GL -name 'xmesa*' ) | \
-	perl -lne 'print $$_, " ", "usr/share/mesa-source/" . $$_' > $@
+	while read x; do echo $$x usr/share/mesa-source/`dirname $$x`; done \
+	> $@
 
 binary: binary-indep binary-arch
 .PHONY: build clean binary-indep binary-arch binary install configure debian/mesa-swx11-source.install

With that packaging issue out of the way, I was able to confirm that
bug #364228 is no more; thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
Finger amu@monk.mit.edu (NOT a valid e-mail address) for more info.



Reply to: