[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: description of fix for #230204 for clean-room reimplmentation



Around 16 o'clock on Apr 21, Branden Robinson wrote:

> In the source file
> <xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_io.c>:

I'll note that the version of KDKBDREP_ioctl_ok in X.Org CVS does:

static int
KDKBDREP_ioctl_ok(int rate, int delay) {
#if defined(KDKBDREP) && !defined(__sparc__)
     /* This ioctl is defined in <linux/kd.h> but is not
        implemented anywhere - must be in some m68k patches. */
   struct kbd_repeat kbdrep_s;

   /* don't change, just test */
   kbdrep_s.rate = -1;
   kbdrep_s.delay = -1;
   if (ioctl( xf86Info.consoleFd, KDKBDREP, &kbdrep_s )) {
       return 0;
   }

This appears functionally equivalent to the specification you included, 
and limits the change to a single line of code.

-keith


Attachment: pgpLyXbA_Yv8J.pgp
Description: PGP signature


Reply to: