[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: debhelper script for maps, languages, formats



On Mon, Jan 16, 2006 at 15:41 +0100, Norbert Preining wrote:
> Thus I ask what you think aobut the following syntax:
> 
> 	dh_installtex	<debhelper options>
> 		-n		# dont modify scripts
> 		--priority=n	# default priority
> 		--flavor=...	# select flavor of the day
> 		items ...
[...]

Looks good to me. Nice work.

> Those who are interested please check the dhinstalltex scripts and the
> to autohelper scripts postinst-tex and postrm-tex.

Two comments, which actually apply also to the already used
postinst-texfonts and postrm-texfonts:

* TeX policy says that update-updmap should be called with option
  --quiet      

* Why do you use 'mktemp -p /tmp'? Shouldn't 'mktemp -t' have the same
  effect and be easier to understand? I had to look at mktemp(1) first
  to undestand that TMPDIR, if set, is used even if the -p option is
  used. 

I am not sure I understand the purpose of
'build_format_if_format_exists' correctly. What's the meaning of the
different arguments? One minor thing: Why do you use

    X=`cat $fmtcnffile | grep "^$2[[:space:]]" || true`

instead of

    X=`grep "^$2[[:space:]]" $fmtcnffile || true`

? Just wondering ...

cheerio
ralf



Reply to: