[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684046: marked as done (unblock: coffeescript/1.3.3-3)

Your message dated Tue, 7 Aug 2012 01:26:04 +0200
with message-id <20120806232604.GH16801@mraw.org>
and subject line Re: Bug#684046: unblock: coffeescript/1.3.3-3
has caused the Debian Bug report #684046,
regarding unblock: coffeescript/1.3.3-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
684046: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684046
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package coffeescript

We have now adjusted coffeescript to use nodejs (not node) as hashbang.

<https://lists.debian.org/debian-devel-announce/2012/07/msg00002.html>,
and consider it ready for inclusion in Wheezy.

Attached is a debdiff of changes made since the version that would've
entered testing had it not been held back by nodejs and bug#614907.


Kind regards, and thanks for your tireless work,

 - Jonas

unblock coffeescript/1.3.3-3

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=da_DK.UTF-8, LC_CTYPE=da_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

diff -Nru coffeescript-1.3.3/debian/changelog coffeescript-1.3.3/debian/changelog
--- coffeescript-1.3.3/debian/changelog	2012-05-23 21:28:43.000000000 +0200
+++ coffeescript-1.3.3/debian/changelog	2012-08-06 14:40:01.000000000 +0200
@@ -1,3 +1,20 @@
+coffeescript (1.3.3-3) unstable; urgency=low
+
+  * Really fix build-depend on nodejs.
+
+ -- Jonas Smedegaard <dr@jones.dk>  Mon, 06 Aug 2012 14:40:00 +0200
+
+coffeescript (1.3.3-2) unstable; urgency=low
+
+  * Fix explicitly build-depend on nodejs (used in cakefile to build
+    coffeescript).
+  * Add patch to call binary /usr/bin/nodejs (not node) during build,
+    adjust rules file to do the same for installed wrappers, and tighten
+    (build-)dependency on nodejs.
+    See bug#614907.
+
+ -- Jonas Smedegaard <dr@jones.dk>  Mon, 06 Aug 2012 02:24:17 +0200
+
 coffeescript (1.3.3-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru coffeescript-1.3.3/debian/control coffeescript-1.3.3/debian/control
--- coffeescript-1.3.3/debian/control	2012-05-23 21:34:48.000000000 +0200
+++ coffeescript-1.3.3/debian/control	2012-08-06 14:38:24.000000000 +0200
@@ -8,6 +8,7 @@
  devscripts,
  debhelper,
  dh-buildinfo,
+ nodejs (>= 0.6.19~dfsg1-3~),
  node-uglify,
  help2man
 Standards-Version: 3.9.3
diff -Nru coffeescript-1.3.3/debian/patches/series coffeescript-1.3.3/debian/patches/series
--- coffeescript-1.3.3/debian/patches/series	2011-08-20 17:15:15.000000000 +0200
+++ coffeescript-1.3.3/debian/patches/series	2012-08-06 02:31:18.000000000 +0200
@@ -1,2 +1,3 @@
 support-system-wide-install.patch
 avoid-tests-during-build.patch
+use_usr-bin-nodejs.patch
diff -Nru coffeescript-1.3.3/debian/patches/use_usr-bin-nodejs.patch coffeescript-1.3.3/debian/patches/use_usr-bin-nodejs.patch
--- coffeescript-1.3.3/debian/patches/use_usr-bin-nodejs.patch	1970-01-01 01:00:00.000000000 +0100
+++ coffeescript-1.3.3/debian/patches/use_usr-bin-nodejs.patch	2012-08-06 02:50:19.000000000 +0200
@@ -0,0 +1,32 @@
+Description: Use /usr/bin/nodejs (not /usr/bin/env node)
+Author: Jonas Smedegaard <dr@jones.dk>
+Forwarded: no
+Last-Update: 2012-08-06
+
+--- a/bin/cake
++++ b/bin/cake
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env node
++#!/usr/bin/nodejs
+ 
+ var path = require('path');
+ var fs   = require('fs');
+--- a/bin/coffee
++++ b/bin/coffee
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env node
++#!/usr/bin/nodejs
+ 
+ var path = require('path');
+ var fs   = require('fs');
+--- a/Cakefile
++++ b/Cakefile
+@@ -34,7 +34,7 @@
+ 
+ # Run a CoffeeScript through our node/coffee interpreter.
+ run = (args, cb) ->
+-  proc =         spawn 'node', ['bin/coffee'].concat(args)
++  proc =         spawn 'nodejs', ['bin/coffee'].concat(args)
+   proc.stderr.on 'data', (buffer) -> console.log buffer.toString()
+   proc.on        'exit', (status) ->
+     process.exit(1) if status != 0
diff -Nru coffeescript-1.3.3/debian/rules coffeescript-1.3.3/debian/rules
--- coffeescript-1.3.3/debian/rules	2012-05-23 21:24:20.000000000 +0200
+++ coffeescript-1.3.3/debian/rules	2012-08-06 02:40:02.000000000 +0200
@@ -29,7 +29,7 @@
 # suppress checking binary file, to not upset dpkg-source
 DEB_COPYRIGHT_CHECK_IGNORE_REGEX = ^documentation/images/logo\.png|debian/(changelog|copyright(|_hints|_newhints))$
 
-CDBS_DEPENDS_coffeescript = nodejs
+CDBS_DEPENDS_coffeescript = nodejs (>= 0.6.19~dfsg1-3~)
 CDBS_RECOMMENDS_libjs-coffeescript = javascript-common
 CDBS_SUGGESTS_coffeescript = libjs-coffeescript
 CDBS_SUGGESTS_libjs-coffeescript = coffeescript
@@ -73,11 +73,11 @@
 	MINIFY=false bin/cake build:browser
 	$(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),,bin/cake test:browser)
 
-	echo '#!/usr/bin/env node' > debian/$(cake)
+	echo '#!/usr/bin/nodejs' > debian/$(cake)
 	echo >> debian/$(cake)
 	echo "require('../lib/coffee-script/lib/coffee-script/cake').run();" >> debian/$(cake)
 
-	echo '#!/usr/bin/env node' > debian/coffee
+	echo '#!/usr/bin/nodejs' > debian/coffee
 	echo >> debian/coffee
 	echo "require('../lib/coffee-script/lib/coffee-script/command').run();" >> debian/coffee

--- End Message ---
--- Begin Message --- 
Hello,

Jonas Smedegaard <dr@jones.dk> (06/08/2012):
> Please unblock package coffeescript
> 
> We have now adjusted coffeescript to use nodejs (not node) as hashbang.
> 
> <https://lists.debian.org/debian-devel-announce/2012/07/msg00002.html>,
> and consider it ready for inclusion in Wheezy.
> 
> Attached is a debdiff of changes made since the version that would've
> entered testing had it not been held back by nodejs and bug#614907.

(what /could/ have been in testing doesn't matter, and we're not adding
new packages at this point anyway.)

Given we're likely not unblocking nodejs, and even if we were, that
package is not even on your list of essential packages
(<[🔎] 20120806160453.GJ3387@jones.dk>), I'll just close this bug report.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: