Re: [Pkg-ocaml-maint-commits] [SCM] sexplib310 packaging branch, build, updated. debian/4.2.11-2
On 12-07-2009, Stefano Zacchiroli <zack@debian.org> wrote:
>
> On Fri, Jul 10, 2009 at 10:19:26PM +0000, Sylvain Le Gall wrote:
>> + * Set debian-branch to build in gbp.conf
>> =20
>> diff --git a/debian/gbp.conf b/debian/gbp.conf
>> index cec628c..0cdb520 100644
>> --- a/debian/gbp.conf
>> +++ b/debian/gbp.conf
>> @@ -1,2 +1,3 @@
>> [DEFAULT]
>> pristine-tar =3D True
>> +debian-branch =3D build
>
> MMMMMhhhh, I'm not sure I like this.
>
> During package preparation, it is customary to do many builds for
> testing and then *the* final build to upload. I usually do the many
> builds staying in master (with debian/patches/ generated, though never
> committed to master), and then I do the final build staying in build.
>
> With that change you just committed I'll be forced to use
> --git-debian-branch manually on the command line during the many
> builds. Which is quite annoying.
I usually do the many build through a git-br alias ignoring warning
(like alias git-br='git-buildpackage -us -uc --git-ignore-new') and then
do a git-buildpackage without ignoring all this for upload.
Enforcing people to be on the "build" branch for the final build is
something desirable to my mind. In my case at least, the final
git-buildpackage will be stopped if I am still on "master".
>
> I think Stephane (back then the only other topgit user among us, in
> this list) used a work-flow similar to mine.
>
Of course, I talked to Stephane about this. At this time, he agree with
me.
> Please revert this change, unless you have strong arguments to have it
> that way.
>
My only strong argument is that it enforce the fact that you must do the
final build on the "build" branch. This is at least a reminder and it
match git-buildpackage way of thinking.
Regards
Sylvain Le Gall
Reply to: