Please point upstream at these pages if you didn't already:
http://wiki.debian.org/UpstreamGuide
http://www.freedesktop.org/wiki/Games/Upstream
You might want to join the games team:
http://wiki.debian.org/Games/Team
meandmyshadow.desktop has executable permissions, which it doesn't need.
Please ask upstream to remove the embedded code copies (tinyformat,
tinygettext, findlocale, DroidSansFallback.ttf), they should be packaged
separately:
http://wiki.debian.org/EmbeddedCodeCopies
I would suggest that the icons should be created from the XCF file using
xcf2png and icotool at build time by upstream, or at least the cmake
stuff should do that if they are missing and the debian/rules file
should remove them on clean and before dh_auto_build.
Please get the patches and manual page included upstream.
The watch file should probably use (\d[\d\.]+(?:rc\d+)?) instead of (.*)
for the version part of the regex and make the -src part optional with
(?:-src)? instead of -src.
No need for the blank line in the watch file.
Please add --parallel to the arguments to dh.
None of the comments in debian/rules look necessary.
It is better to use --fail-missing with dh_install
You might want to add a longtitle to debian/menu.
The README includes compilation info, which isn't needed in binary
packages. The other info basically duplicates the package description so
I would not ship the upstream README.
There are a bunch of files in ./src/libs/ with the incorrect address for
the FSF, you might want to get the upstreams for those to fix that if
they haven't already.
tools/messages.pot.sh appears to be POSIX sh compatible, so there is no
need for it to require bash.
The package descriptions are duplicates of each other. They should
describe themselves, not the game. Check warzone2100 for an example of
how to do it right.
Some of the images contain pre-rendered text, it would be better to
render this at runtime so it can be translated to the user's locale.
The music is pre-generated, pre-mixed and looks to be created with
proprietary software, which means that Debian users are not on an equal
footing with the creator of the music.
There is some audio made in sfxr that is missing its source files, sfxr
is also not in Debian yet so we (and our users) wouldn't be able to
modify the sfxr source and remix these audio files.
These two files were rendered from Inkscape and are missing their source
SVG files:
./data/gfx/menu/title.png
./data/gfx/actions.png
A bunch of PNG files appear to have been created in the GIMP. Did
upstream discard the XCF versions or are they hiding them somewhere?
Blokletters-Viltstift.ttf appears to be a "Freeware" font that is
copyrighted and doesn't allow distribution, at least according to the
font metadata. Same with Knewave.
Automated checks:
http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
lintian:
W: meandmyshadow source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
I: meandmyshadow-dbg: using-first-person-in-description line 1: My
P: meandmyshadow-dbg: data.tar.xz-member-without-dpkg-pre-depends
I: meandmyshadow-dbg: using-first-person-in-description line 12: My
P: meandmyshadow: data.tar.xz-member-without-dpkg-pre-depends
I: meandmyshadow: using-first-person-in-description line 1: My
P: meandmyshadow-data: data.tar.xz-member-without-dpkg-pre-depends
I: meandmyshadow-data: using-first-person-in-description line 1: My
I: meandmyshadow-data: using-first-person-in-description line 12: My
I: meandmyshadow-data: font-in-non-font-package usr/share/games/meandmyshadow/data/font/Blokletters-Viltstift.ttf
I: meandmyshadow-data: font-in-non-font-package usr/share/games/meandmyshadow/data/font/DroidSansFallback.ttf
I: meandmyshadow-data: font-in-non-font-package usr/share/games/meandmyshadow/data/font/knewave.ttf
I: meandmyshadow-data: package-contains-empty-directory usr/share/games/meandmyshadow/data/levels/
pep8:
./tools/extract_pot.py:18:11: E401 multiple imports on one line
./tools/extract_pot.py:44:32: E231 missing whitespace after ','
./tools/extract_pot.py:59:1: E302 expected 2 blank lines, found 1
./tools/extract_pot.py:60:23: E231 missing whitespace after ','
./tools/extract_pot.py:66:22: E702 multiple statements on one line (semicolon)
./tools/extract_pot.py:69:1: E302 expected 2 blank lines, found 1
./tools/extract_pot.py:78:26: E201 whitespace after '('
./tools/extract_pot.py:78:30: E202 whitespace before ')'
./tools/extract_pot.py:79:28: E201 whitespace after '('
./tools/extract_pot.py:79:32: E202 whitespace before ')'
./tools/extract_pot.py:87:1: E302 expected 2 blank lines, found 1
./tools/extract_pot.py:90:80: E501 line too long (96 characters)
./tools/extract_pot.py:109:1: E302 expected 2 blank lines, found 1
fontlint:
This font contains both a 'kern' table and a 'GPOS' table.
The 'kern' table will only be read if there is no 'kern' feature in 'GPOS'.
Validation DroidSansFallback ...Failed
Self Intersecting Glyph
Missing Points at Extrema
Validation Knewave-Regular ...Failed
Self Intersecting Glyph
Wrong Direction
Missing Points at Extrema
The following table(s) in the font have been ignored by FontForge
Ignoring 'LTSH' linear threshold table
Ignoring 'VDMX' vertical device metrics table
Ignoring 'hdmx' horizontal device metrics table
Validation Blokletters-Viltstift ...Failed
Self Intersecting Glyph
Missing Points at Extrema
This font contains both a 'kern' table and a 'GPOS' table.
The 'kern' table will only be read if there is no 'kern' feature in 'GPOS'.
msgfmt:
./data/locale/de.po:923: empty `msgstr' entry ignored
./data/locale/de.po:1071: empty `msgstr' entry ignored
./data/locale/de.po:1079: empty `msgstr' entry ignored
msgfmt: found 3 fatal errors
msgfmt: ./data/locale/messages.pot: warning: source file contains fuzzy translation
msgfmt: ./data/locale/messages.pot: warning: PO file header fuzzy
warning: older versions of msgfmt will give an error on this
msgfmt: found 236 fatal errors
msgfmt: ./data/levelpacks/default/locale/messages.pot: warning: source file contains fuzzy translation
msgfmt: ./data/levelpacks/default/locale/messages.pot: warning: PO file header fuzzy
warning: older versions of msgfmt will give an error on this
msgfmt: found 21 fatal errors
./data/levelpacks/default/locale/ru.po:7: header field `Project-Id-Version' still has the initial default value
msgfmt: ./data/levelpacks/tutorial/locale/messages.pot: warning: source file contains fuzzy translation
msgfmt: ./data/levelpacks/tutorial/locale/messages.pot: warning: PO file header fuzzy
warning: older versions of msgfmt will give an error on this
msgfmt: found 69 fatal errors
./data/levelpacks/tutorial/locale/ru.po:7: header field `Project-Id-Version' still has the initial default value
./data/levelpacks/tutorial/locale/ru.po:22: `msgid' and `msgstr' entries do not both end with '\n'
msgfmt: found 1 fatal error
msgfmt: ./data/levelpacks/classic/locale/messages.pot: warning: source file contains fuzzy translation
msgfmt: ./data/levelpacks/classic/locale/messages.pot: warning: PO file header fuzzy
warning: older versions of msgfmt will give an error on this
msgfmt: found 26 fatal errors
./data/levelpacks/classic/locale/ru.po:7: header field `Project-Id-Version' still has the initial default value
POFileChecker and friends report a bunch of stuff.
isutf8:
./src/libs/tinygettext/language.cpp: line 194, char 1, byte offset 35: invalid UTF-8 code
./icons/windows-icon/res.rc: line 16, char 1, byte offset 4: invalid UTF-8 code
--
bye,
pabs
http://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part