Bug#657428: RFS: surf -- simple web browser (QA upload)
owner 657428 !
thanks
* Vasudev Kamath <kamathvasudev@gmail.com>, 2012-01-26, 13:17:
dget -x http://mentors.debian.net/debian/pool/main/s/surf/surf_0.4.1-5.dsc
This package builds without any lintian warnings. Below is the changelog
surf (0.4.1-5) unstable; urgency=low
* QA upload.
Here, for completeness, I would mention that you changed the Maintainer
field to Debian QA Group.
* debian/control:
+ Bumped Standards-Version to 3.9.2
Did this require any changes to the packaging?
* debian/surf.postinst:
+ Reduced the update-alternative priority to 30 as per request from user
to the previous maintainer
Hmm. Was there a bug report about that?
* debian/rules:
+ Introduced dpkg-buildflags by patching config.mk with
dpkg-buildflags.patch
This is formulated in a confusing way. I had to look at sources to
understand what happened.
Okay, so there are two changes:
1) You added a patch for config.mk that makes it honour {C,CPP,LD}FLAGS
from environment.
2) You added a hunk to debian/rules that exports these variables.
The hunk looks like this:
+#export DH_VERBOSE=1
+
+-include /usr/share/dpkg/buildflags.mk
+export CPPFLAGS CFLAGS LDFLAGS
Unfortunately, this _won't_ do the right thing for these dpkg-dev
versions that didn't provide the /usr/share/dpkg/buildflags.mk file.
Please see
<http://lists.debian.org/debian-mentors/2011/10/msg00307.html> to
understand why.
* debian/source/local-options:
+ Introduced local-options to undo the patches
No, no, no. debian/source/local-options doesn't belong in the source
package. And if you look carefully, dpkg-source in fact didn't include
it in .debian.tar.gz.
--
Jakub Wilk
Reply to: