Re: RFR: eegdev

[Michael Hanke <mih@debian.org>]

Hi,

On Fri, Jan 20, 2012 at 12:33:44AM +0100, Nicolas Bourdaud wrote:
> I would be glad if someone review this package.

The packaging looks pretty good. There are a few things that you could
take a look at.

The comments at the top of debian/rules should go away -- it is no
longer a sample rules file.

When I build the package on my i386 laptop (up-to-date wheezy) the build
hangs in one of the tests until I kill it (reproduced every time):

make[4]: Entering directory `/home/michael/debian/cnbi/eegdev/tests'
PASS: verify-cast.sh
PASS: verifysplit
PASS: syseegfile
	Testing biosemi with float data type
	Testing biosemi with double data type
PASS: testfakeact2.sh
		error caught (97) Address family not supported by protocol
^C

When I build the package with 'nocheck' it builds.

I noticed the eegdev-plugins-free binary package name and that the
build uses this configuration

    Core library build : yes
    --------------------------
    EEG file support : yes
    Biosemi support  : yes
    gTec support     : no
    Neurosky support : no
    TobiIA support   : yes

Do the two missing plugins depend on something that is not in Debian? Or
that is non-free? It looks like (at least some of) the code for these
plugins is shipped with the package. I didn't see any copyright notice
that would indicate 3rd-party code. It might make sense to put some
information about the "missing" plugins into README.Debian or
README.source, depending on why they are missing and whether there are
plans to add them later on.

I have updated the information on this package in the Debian Science
taskfiles.

Cheers,

Michael




-- 
Michael Hanke
http://mih.voxindeserto.de