Re: RFS: python-x2go
(I don't intend to sponsor this package.)
* Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 2012-01-19, 23:41:
dget -x http://mentors.debian.net/debian/pool/main/p/python-x2go/python-x2go_0.1.1.8-4.dsc
I'd remove the commented-out commands from debian/rules.
I'd also remove also explicit "install" and "binary-indep" targets,
since the wildcard "%" do exactly the same.
You provide "build-arch" and "build-indep" targets, but they do
something different than the "build" target. That's bad.
(dpkg-buildpackage currently doesn't use build-* targets, but it might
start doing so in the future.)
You should not explicitly delete debian/*.log, debian/<packagename>,
etc. dh_clean takes care of this.
Deleting debian/patches in the clean target is certainly a bad idea!
You define PYVERS variable in debian/rules, but you don't use it
anywhere.
Upstream provides a test suite, please run it at build time (preferably
using all supported Python versions).
Does this package support Python 2.5? debian/pyversions says it does,
XS-Python-Version says it doesn't. Please use only one of them, BTW.
XB-Python-Version is deprecated, please remove it.
">= 0.13.0-0~0" is a pretty weird version constraint. Maybe ">= 0.13.0"
or even ">= 0.13" could be used instead?
You should close the ITP in the changelog.
I (and most other sponsor here) normally require one changelog entry per
upload to the archive.
Lintian emits some experimental and informative tags that you might want
to fix:
X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/frames.html usr/share/doc/python-x2go/html/index.html
X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.control._stdout-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.info._stdout-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.terminal._stdout-module.html
X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._gconf-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._gconf-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._gconf-module.html
X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._file-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._file-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._file-module.html
X: python-x2go: duplicate-files usr/share/doc/python-x2go/html/toc-x2go.backends.printing._winreg-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.profiles._winreg-module.html usr/share/doc/python-x2go/html/toc-x2go.backends.settings._winreg-module.html
I: python-x2go: possible-documentation-but-no-doc-base-registration
It looks like documentation takes much more space than the rest of the
package (7.6M vs 780K unpacked). Since end users don't need the
documentation, maybe it'd be worthwhile to split it into a separate
package?
I'd exclude x2go.tests module from the binary package.
setup.py have install_requires = ['setuptools', ...], but the package
doesn't depend on python-setuptools. So either setup.py or the Depends
is wrong (probably the former).
x2go/monkey_patch_paramiko.py has a different license than the rest of
the code, but this is not documented in debian/copyright.
The strange status of x2go/gevent_subprocess.py is probably worth
documenting, too.
$ pyflakes . | grep ': undefined name'
./x2go/mimebox.py:100: undefined name 'mimebox_actions'
./x2go/checkhosts.py:225: undefined name 'random'
./x2go/checkhosts.py:225: undefined name 'string'
./x2go/checkhosts.py:225: undefined name 'string'
./x2go/log.py:123: undefined name 'types'
./x2go/log.py:125: undefined name 'types'
./x2go/mimeboxactions.py:92: undefined name 'self'
./x2go/mimeboxactions.py:100: undefined name 'self'
./x2go/mimeboxactions.py:152: undefined name 'WindowsError'
./x2go/utils.py:63: undefined name 'stdout'
./x2go/client.py:997: undefined name 'X2goSessionExceptionRegistryException'
./x2go/printactions.py:98: undefined name 'self'
./x2go/printactions.py:106: undefined name 'self'
./x2go/printactions.py:191: undefined name 'WindowsError'
./x2go/backends/profiles/_gconf.py:51: undefined name 'X2goNotImplementedYetException'
./x2go/backends/profiles/_winreg.py:51: undefined name 'X2goNotImplementedYetException'
./x2go/backends/profiles/_httpsbroker.py:50: undefined name 'X2goNotImplementedYetException'
./x2go/backends/profiles/_file.py:83: undefined name 'check_profile_id_or_name'
./x2go/backends/settings/_gconf.py:64: undefined name 'X2goNotImplementedYetException'
./x2go/backends/settings/_winreg.py:64: undefined name 'X2goNotImplementedYetException'
./x2go/backends/control/_stdout.py:171: undefined name 'SSHException'
./x2go/backends/printing/_winreg.py:75: undefined name 'X2goNotImplementedYetException'
./x2go/backends/terminal/_stdout.py:325: undefined name 'X2goTerminalSessionException'
./x2go/backends/terminal/_stdout.py:942: undefined name 'X2goTerminalSessionException'
./x2go/backends/terminal/_stdout.py:944: undefined name 'X2goTerminalSessionException'
I believe that the above are mostly (or all) true positives.
--
Jakub Wilk
Reply to: