Re: RFS: blogofile
On Wed, Oct 26, 2011 at 4:32 PM, Andreas Rütten <AndreasRuetten@gmx.de> wrote:
> I am looking for a sponsor for my package "blogofile".
>
> * Package name : blogofile
> Version : 0.7.1-1
> Upstream Author : Ryan McGuire <ryan@enigmacurry.com>
> * URL : http://www.blogofile.com/
> * License : Expat (MIT)
> Section : web
>
> It builds those binary packages:
>
> blogofile - Static website compiler and blog engine
> blogofile-converters - Blog converter collection for Blogofile
I'm not a DD, so I can't actually sponsor this. It sounds like an
interesting package, so I did a quick review. Building in a clean sid
chroot, I get this lintian error from the produced binary package:
E: blogofile: python-script-but-no-python-dep usr/bin/blogofile
N:
N: Packages with Python scripts should depend on the package python. Those
N: with scripts that specify a specific version of Python must depend on
N: that version of Python (exactly).
N:
N: For example, if a script in the package uses #!/usr/bin/python, the
N: package needs a dependency on python. If a script uses
N: #!/usr/bin/python2.6, the package needs a dependency on python2.6. A
N: dependency on python (>= 2.6) is not correct, since later versions of
N: Python may not provide the /usr/bin/python2.6 binary.
N:
N: If you are using debhelper, adding ${python:Depends} to the Depends
N: field and ensuring dh_pysupport or dh_pycentral are run during the build
N: should take care of adding the correct dependency.
N:
N: In some cases a weaker relationship, such as Suggests or Recommends,
N: will be more appropriate.
N:
N: Severity: important, Certainty: certain
N:
N: Check: scripts, Type: binary
Looking at DEBIAN/control in the resulting deb confirms that there is
no direct python dependency for blogofile. Reading over the log file
reveals that dh_python2 is never actually run. It took me awhile to
figure it out, but it seems you have a one character typo. Your rules
file has:
%:
dh $@ --buildsystem=python_distutils --with-python2
It should be:
%:
dh $@ --buildsystem=python_distutils --with python2
Notice, no hyphen between with and python.
-- Andrew Starr-Bochicchio
Ubuntu Developer <https://launchpad.net/~andrewsomething>
Debian Maintainer
<http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
PGP/GPG Key ID: D53FDCB1
Reply to: