[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libqtintf4 (ping)



On 2009-12-18, Matthias Klumpp <matthias@nlinux.org> wrote:
> The package is lintian-clean. There were some concerns about the
> build-script, but because it's a really small lib there should be no
> problem in building this. 

The way it is built, it takes around 1G of memory to build. This *needs*
to be fixed. it might be a small lib, but the way it is built is just
plain wrong. Especially since this can be easily fixed.


The moc output files *must* be regenerated on build, else you end up
with issues like:

In file included from qtpas.cpp:370:
lib/hooks//qwebsettings.cpp_mk:14:2: error: #error "This file was
generated using the moc from 4.5.2. It"
lib/hooks//qwebsettings.cpp_mk:15:2: error: #error "cannot be used with
the include files from this version of Qt."
lib/hooks//qwebsettings.cpp_mk:16:2: error: #error "(The moc has changed
too much.)"

from next Qt upload.


and the build script *needs* to be fixed so that it actually fails when
build fails.

dpatch apply-all
applying patch 01_buildscript.patch to ./ ... ok.
bash /tmp/libqtintf4-1.72Qt4.5.2/compile_lib.sh
Please Modify location of Qt4 in this script
touch build-stamp
 fakeroot debian/rules binary
 dh_testdir
 dh_testroot
 dh_clean -k
 dh_installdirs
 dh_install
 dh_install: libqt4intf5 missing files (libqt4intf.so.*), aborting

/Sune


Reply to: