On Sun, Nov 29, 2009 at 11:55:48PM +0100, ERSEK Laszlo wrote: >Dear Mentors, > >I kindly request you to review my package lbzip2-0.18-1. The package >is located at > >http://mentors.debian.net/debian/pool/main/l/lbzip2/ > >Changes: > > >* New upstream release: > - Add sanity checks to both decompressors. > - Remove input FILE operands. > - Implement options --keep and --force. > - Copy file attributes from original to (de)compressed. > - Add new exit status 4 to signal warnings. > - (Author eats his own dog-food, replaced bzip2 with lbzip2 on his system.) >* Author switched to cvsnt from cvs; change date separators from "-" to "/" > in the substituted $Id$ value in debian/patches/makefile. >* Adapt line numbers in debian/patches/man-inst-paths to updated manual page. > > >As suggested earlier, I checked the package with > > lintian --info --display-info --display-experimental --pedantic \ > --show-overrides --checksums --color auto ... > >in a sid pbuilder. Lintian displayed one warning (reformatted here): > > W: lbzip2: manpage-has-errors-from-man usr/share/man/man1/lbzip2.1.gz > Invalid or incomplete multibyte or wide character > >I believe #555330 and #555331 may lurk in the background. > >http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555330 >http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=555331 > >Thank you very much, >lacos >(deb-0_18-1-try-01) If you agree, I'll upload it with the following changes: Run the following three commands: cd lbzip2 gzip -dc lbzip2_0.18.orig.tar.gz | bzip2 -9 - > lbzip2_0.18.orig.tar.bz2 touch -r lbzip2_0.18.orig.tar.gz lbzip2_0.18.orig.tar.bz2 and apply the following patch: diff -urNp lbzip2-0.18/debian/control lbzip2-0.18/debian/control --- lbzip2-0.18/debian/control 2009-11-30 18:28:37.000000000 +1100 +++ lbzip2-0.18/debian/control 2009-11-30 18:14:03.000000000 +1100 @@ -2,7 +2,7 @@ Source: lbzip2 Section: utils Priority: extra Maintainer: Laszlo Ersek <lacos@caesar.elte.hu> -Build-Depends: debhelper (>= 5), libbz2-dev, sharutils, quilt +Build-Depends: debhelper (>= 7), libbz2-dev, sharutils Standards-Version: 3.8.3 Homepage: http://lacos.hu/ --- lbzip2-0.18/debian/rules 2009-11-30 18:28:37.000000000 +1100 +++ lbzip2-0.18/debian/rules 2009-11-30 18:15:24.000000000 +1100 @@ -1,7 +1,5 @@ #!/usr/bin/make -f -include /usr/share/quilt/quilt.make - # Do not #define NDEBUG in CFLAGS! export CC = gcc @@ -28,7 +26,7 @@ else endif build: build-stamp -build-stamp: $(QUILT_STAMPFN) +build-stamp: dh_testdir $(MAKE) touch $@ @@ -39,7 +37,6 @@ clean: rm -f build-stamp [ ! -f Makefile ] || $(MAKE) clean dh_clean - [ ! -f $(QUILT_STAMPFN) ] || debian/rules unpatch install: build dh_testdir diff -urNp lbzip2-0.18/debian/source/format lbzip2-0.18/debian/source/format --- lbzip2-0.18/debian/source/format 1970-01-01 10:00:00.000000000 +1000 +++ lbzip2-0.18/debian/source/format 2009-11-23 21:30:16.000000000 +1100 @@ -0,0 +1 @@ +3.0 (quilt) diff -urNp lbzip2-0.18/debian/source/options lbzip2-0.18/debian/source/options --- lbzip2-0.18/debian/source/options 1970-01-01 10:00:00.000000000 +1000 +++ lbzip2-0.18/debian/source/options 2009-11-23 21:37:44.000000000 +1100 @@ -0,0 +1,2 @@ +compression = "bzip2" +compression-level = 9
Attachment:
signature.asc
Description: Digital signature