Re: RFS: dynamite (updated and adopted package)
Hi Vincent,
thanks for your reviews. I'll reply here, as this is the longest one.
On Thu, 08 May 2008 21:26:21 +0200 Vincent Bernat wrote:
> As new maintainer, you should acknowledge NMU (#259294).
Yepp, forgot that, fixed now (not yet uploaded, though).
> I think that
> you should Build-Conflicts against autoconf2.13 and automake1.4 like you
> did for unshield.
I did not, the Build-Conflicts are from the old maintainer, but they
won't hurt if added.
> It would be nice to use machine-readable format for debian/copyright. I
> think that you should also add ltmain.sh license in it (I have forgotten
> it for unshield too).
machine-readable is a good hint, I did that for unshield, but not for
the other two.
But should I really add copyright information off *all* Makefile.in,
aclocal.m4, config.guess, config.rpath, config.sub, configure, depcomp,
install-sh, ltmain.sh and missing?
> Remove the mention that debian/rules is a sample file.
Eh, yepp, done.
> And add an Homepage field in debian/control (I have also forgotten this
> for unshield !).
Well, with which value? I thought about it before
uploading, but www.synce.org contains no information about
unshield/dynamite/orange. The only possible would be
sf.net/projects/synce, but that's not really a homepage.
Regards
Evgeni
Reply to: