[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://solaar/{solaar.templates}



Christian PERRIER wrote:
>  _Description: Use plugdev group?
>   By default, the Logitech receiver devices are only accessible by the root user.
>   .
> + To allow access to unprivileged users (through solaar), the needed ACLs can be
>   applied, either by the ConsoleKit or systemd daemon, to the current seat (logged-in user).
>   Right now, ${SEAT_DAEMON_STATUS} daemon is running.
>   .
> + If neither of these daemons is installed on the system, or you want to make
> + the receiver accessible to users logged-in remotely, members of the "plugdev"
>   system group can be given access to the receiver devices.
>   .
> + If you do use the "plugdev" group, don't forget to make sure all desktop
>   users are members of the plugdev system group. You can add new members to the
>   group by running, as root:
>       gpasswd --add <username> plugdev
> + For the group membership to take effect, the affected users have to logout
> + and login again.
> 
> I think this should be this way: Justin will probably confirm.

The one-word forms are the nouns ("a login"); you need the verbs,
which have a hole in the middle in case they need to accommodate an
object ("to log [somebody] in/out").

Otherwise I like all your changes, but the whole thing still feels
convoluted and backwards - okay, something is granting users access
to something, but it takes some effort to work out what.  Even once
I've got that sorted out it isn't clear what the actual question is.

Also, the statement about defaults is misleading: "by default" on a
vanilla Jessie desktop install, systemd (or do I mean logind) ought
to take care of everything.

Also, if the device ACLs give special access to the user sitting at
the console, that user isn't exactly "unprivileged".

Also, while I'm not entirely used to this "seat" terminology, I think
there's a problem with how this phrases it.  A "logged-in user" isn't
necessarily on the "current seat" - I might be logged in via SSH (in
which case, as it goes on to imply, I won't get Solaar access).

Also, what values can that variable take?  If it only allows for
"consolekit/systemd" I might prefer to say "*the* systemd daemon", but
that won't work if "neither" is a possible expansion.

Also, the package systemd (or even systemd-sysv) might be installed
without the daemon currently being PID 1.

Also, do we really need to tell admins to add *all* desktop users to
"plugdev"?  I mean, if I don't get to institute a complex caste system
where people have to come to me begging for the privilege of being
added to group "floppy" then I might as well do it via "users".

Also, the Debian Way is to use adduser, not invoke gpasswd direct.

(Also, users can activate new group privileges by saying "su - $USER",
but that won't help for a desktop session.)

Okay, how much do I need to rewrite this?

    Please specify how non-root users should be given access to the Logitech
    receiver devices.
    .
    If systemd or consolekit are in use, they can apply ACLs to make them
    accessible via Solaar for the user logged in on the current seat. Right
    now, ${SEAT_DAEMON_STATUS} daemon is running.
    .
    If neither of these daemons is in use, or if the receiver should also be
    accessible for remotely logged in users, it is possible to grant access
    for members of the "plugdev" system group.
    .
    If you do use the "plugdev" group, don't forget to make sure all the
    appropriate users are members of that group. You can add new members to
    the group by running, as root:
        adduser <username> plugdev
    For the group membership to take effect, the affected users need to log
    out and back in again.

Meanwhile in the control file:

> Package: solaar
> Architecture: all

(Assuming the synopsis is accurate that might be better as linux-any.)

[...]
> Description: Logitech Unifying Receiver peripherals manager for Linux
>  Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
>  It is able to pair/unpair devices to the receiver, and for some devices read
>  battery status.

That needs another "to" - it is able to do one thing and in some
cases ^to^ do another.

It would also be more informative if it included the word "wireless"
somewhere.  Easy enough:

   Solaar is a Linux device manager for Logitech's Unifying Receiver wireless
   peripherals. It is able to pair/unpair devices to the receiver, and for
   some devices to read battery status.

> Package: solaar-gnome3
[...]
> Description: gnome-shell/Unity integration for Solaar
               GNOME Shell

>  Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
>  It is able to pair/unpair devices to the receiver, and for some devices read
>  battery status.

As above.

>  .
>  This metapackage ensures integration with gnome-shell/Unity.

As above.

Why The Name footnote: Solar is a Logitech brandname, Solaar is...
a Francophone rapper?
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru solaar-0.9.2+dfsg.pristine/debian/control solaar-0.9.2+dfsg/debian/control
--- solaar-0.9.2+dfsg.pristine/debian/control	2014-07-06 22:13:24.000000000 +0100
+++ solaar-0.9.2+dfsg/debian/control	2014-09-21 23:05:22.353788169 +0100
@@ -20,9 +20,9 @@
  python-dbus (>= 1.1.0), upower
 Suggests: gir1.2-appindicator3-0.1, solaar-gnome3 (= ${source:Version})
 Description: Logitech Unifying Receiver peripherals manager for Linux
- Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
- It is able to pair/unpair devices to the receiver, and for some devices read
- battery status.
+ Solaar is a Linux device manager for Logitech's Unifying Receiver wireless
+ peripherals. It is able to pair/unpair devices to the receiver, and for
+ some devices to read battery status.
 
 Package: solaar-gnome3
 Architecture: all
@@ -31,9 +31,9 @@
  gir1.2-appindicator3-0.1, gnome-shell (>= 3.4) | unity (>= 5.10),
  ${solaar:Gnome-Icon-Theme}
 Enhances: solaar
-Description: gnome-shell/Unity integration for Solaar
- Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
- It is able to pair/unpair devices to the receiver, and for some devices read
- battery status.
+Description: GNOME Shell/Unity integration for Solaar
+ Solaar is a Linux device manager for Logitech's Unifying Receiver wireless
+ peripherals. It is able to pair/unpair devices to the receiver, and for
+ some devices to read battery status.
  .
- This metapackage ensures integration with gnome-shell/Unity.
+ This metapackage ensures integration with GNOME Shell/Unity.
diff -ru solaar-0.9.2+dfsg.pristine/debian/solaar.templates solaar-0.9.2+dfsg/debian/solaar.templates
--- solaar-0.9.2+dfsg.pristine/debian/solaar.templates	2014-06-14 21:45:53.000000000 +0100
+++ solaar-0.9.2+dfsg/debian/solaar.templates	2014-09-21 22:56:25.902188778 +0100
@@ -1,21 +1,23 @@
 Template: solaar/use_plugdev_group
 Type: boolean
 Default: false
+#flag:comment:3
+# Translators : DO NOT TRANSLATE the ${SEAT_DAEMON_STATUS} variable name
 _Description: Use plugdev group?
- By default, the Logitech receiver devices are only accessible by the root user.
+ Please specify how non-root users should be given access to the Logitech
+ receiver devices.
  .
- To allow access to regular users (through solaar), the needed ACLs can be
- applied, either by the ConsoleKit or systemd daemon, to the current seat
- (logged-in user).
- Right now, ${SEAT_DAEMON_STATUS} daemon is running.
+ If systemd or consolekit are in use, they can apply ACLs to make them
+ accessible via Solaar for the user logged in on the current seat. Right
+ now, ${SEAT_DAEMON_STATUS} daemon is running.
  .
- If neither of these daemons is installed on your system, or you want to make
- the receiver accessible to ssh logged-in through ssh, members of the 'plugdev'
- system group can be given access to the receiver devices.
+ If neither of these daemons is in use, or if the receiver should also be
+ accessible for remotely logged in users, it is possible to grant access
+ for members of the "plugdev" system group.
  .
- If you do use the 'plugdev' group, don't forget to make sure all your desktop
- users are members of the plugdev system group. You can add new members to the
- group by running, as root:
-     gpasswd --add <username> plugdev
- For the group membership to take effect, the affected users have to log-out
- and log-in again.
+ If you do use the "plugdev" group, don't forget to make sure all the
+ appropriate users are members of that group. You can add new members to
+ the group by running, as root:
+     adduser <username> plugdev
+ For the group membership to take effect, the affected users need to log
+ out and back in again.
Template: solaar/use_plugdev_group
Type: boolean
Default: false
#flag:comment:3
# Translators : DO NOT TRANSLATE the ${SEAT_DAEMON_STATUS} variable name
_Description: Use plugdev group?
 Please specify how non-root users should be given access to the Logitech
 receiver devices.
 .
 If systemd or consolekit are in use, they can apply ACLs to make them
 accessible via Solaar for the user logged in on the current seat. Right
 now, ${SEAT_DAEMON_STATUS} daemon is running.
 .
 If neither of these daemons is in use, or if the receiver should also be
 accessible for remotely logged in users, it is possible to grant access
 for members of the "plugdev" system group.
 .
 If you do use the "plugdev" group, don't forget to make sure all the
 appropriate users are members of that group. You can add new members to
 the group by running, as root:
     adduser <username> plugdev
 For the group membership to take effect, the affected users need to log
 out and back in again.
Source: solaar
Section: misc
Priority: optional
Maintainer: Stephen Kitt <skitt@debian.org>
Build-Depends: debhelper (>= 9)
Build-Depends-Indep: python, po-debconf
X-Python-Version: >= 2.7
X-Python3-Version: >= 3.2
Standards-Version: 3.9.5
Homepage: http://pwr.github.io/Solaar
Vcs-Git: git://anonscm.debian.org/collab-maint/solaar.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/solaar.git

Package: solaar
Architecture: all
Depends: ${misc:Depends}, ${debconf:Depends}, udev (>= 175), passwd | adduser,
 ${python:Depends}, python-pyudev (>= 0.13), python-gi (>= 3.2), gir1.2-gtk-3.0 (>= 3.4),
 ${solaar:Desktop-Icon-Theme}
Recommends: gir1.2-notify-0.7, consolekit (>= 0.4.3) | systemd (>= 44),
 python-dbus (>= 1.1.0), upower
Suggests: gir1.2-appindicator3-0.1, solaar-gnome3 (= ${source:Version})
Description: Logitech Unifying Receiver peripherals manager for Linux
 Solaar is a Linux device manager for Logitech's Unifying Receiver wireless
 peripherals. It is able to pair/unpair devices to the receiver, and for
 some devices to read battery status.

Package: solaar-gnome3
Architecture: all
Section: gnome
Depends: ${misc:Depends}, solaar (= ${source:Version}),
 gir1.2-appindicator3-0.1, gnome-shell (>= 3.4) | unity (>= 5.10),
 ${solaar:Gnome-Icon-Theme}
Enhances: solaar
Description: GNOME Shell/Unity integration for Solaar
 Solaar is a Linux device manager for Logitech's Unifying Receiver wireless
 peripherals. It is able to pair/unpair devices to the receiver, and for
 some devices to read battery status.
 .
 This metapackage ensures integration with GNOME Shell/Unity.

Reply to: