[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://solaar/{solaar.templates}



Please find, for review, the debconf templates and packages descriptions for the solaar source package.

This review will last from Sunday, September 21, 2014 to Wednesday, October 01, 2014.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- solaar.old/debian/solaar.templates	2014-09-17 06:57:04.472944105 +0200
+++ solaar/debian/solaar.templates	2014-09-21 17:18:01.060315643 +0200
@@ -1,21 +1,23 @@
 Template: solaar/use_plugdev_group
 Type: boolean
 Default: false
+#flag:comment:3
+# Translators : DO NOT TRANSLATE the ${SEAT_DAEMON_STATUS} variable name


This comment will help translator to avoid common mistakes

 _Description: Use plugdev group?
  By default, the Logitech receiver devices are only accessible by the root user.
  .
- To allow access to regular users (through solaar), the needed ACLs can be
+ To allow access to unprivileged users (through solaar), the needed
  ACLs can be

We more often use "unprivileged users" in opposition to "root"

  applied, either by the ConsoleKit or systemd daemon, to the current seat
  (logged-in user).
  Right now, ${SEAT_DAEMON_STATUS} daemon is running.
  .
- If neither of these daemons is installed on your system, or you want to make
- the receiver accessible to ssh logged-in through ssh, members of the 'plugdev'
+ If neither of these daemons is installed on the system, or you want to make
+ the receiver accessible to users logged-in remotely, members of the "plugdev"
  system group can be given access to the receiver devices.

This was probably a typo, I guess

  .
- If you do use the 'plugdev' group, don't forget to make sure all your desktop
+ If you do use the "plugdev" group, don't forget to make sure all desktop

Standard debian-l10n-english quoting.

  users are members of the plugdev system group. You can add new members to the
  group by running, as root:
      gpasswd --add <username> plugdev
- For the group membership to take effect, the affected users have to log-out
- and log-in again.
+ For the group membership to take effect, the affected users have to logout
+ and login again.

I think this should be this way: Justin will probably confirm.

-- 


Template: solaar/use_plugdev_group
Type: boolean
Default: false
#flag:comment:3
# Translators : DO NOT TRANSLATE the ${SEAT_DAEMON_STATUS} variable name
_Description: Use plugdev group?
 By default, the Logitech receiver devices are only accessible by the root user.
 .
 To allow access to unprivileged users (through solaar), the needed ACLs can be
 applied, either by the ConsoleKit or systemd daemon, to the current seat
 (logged-in user).
 Right now, ${SEAT_DAEMON_STATUS} daemon is running.
 .
 If neither of these daemons is installed on the system, or you want to make
 the receiver accessible to users logged-in remotely, members of the "plugdev"
 system group can be given access to the receiver devices.
 .
 If you do use the "plugdev" group, don't forget to make sure all desktop
 users are members of the plugdev system group. You can add new members to the
 group by running, as root:
     gpasswd --add <username> plugdev
 For the group membership to take effect, the affected users have to logout
 and login again.
--- solaar.old/debian/solaar.templates	2014-09-17 06:57:04.472944105 +0200
+++ solaar/debian/solaar.templates	2014-09-21 17:18:01.060315643 +0200
@@ -1,21 +1,23 @@
 Template: solaar/use_plugdev_group
 Type: boolean
 Default: false
+#flag:comment:3
+# Translators : DO NOT TRANSLATE the ${SEAT_DAEMON_STATUS} variable name
 _Description: Use plugdev group?
  By default, the Logitech receiver devices are only accessible by the root user.
  .
- To allow access to regular users (through solaar), the needed ACLs can be
+ To allow access to unprivileged users (through solaar), the needed ACLs can be
  applied, either by the ConsoleKit or systemd daemon, to the current seat
  (logged-in user).
  Right now, ${SEAT_DAEMON_STATUS} daemon is running.
  .
- If neither of these daemons is installed on your system, or you want to make
- the receiver accessible to ssh logged-in through ssh, members of the 'plugdev'
+ If neither of these daemons is installed on the system, or you want to make
+ the receiver accessible to users logged-in remotely, members of the "plugdev"
  system group can be given access to the receiver devices.
  .
- If you do use the 'plugdev' group, don't forget to make sure all your desktop
+ If you do use the "plugdev" group, don't forget to make sure all desktop
  users are members of the plugdev system group. You can add new members to the
  group by running, as root:
      gpasswd --add <username> plugdev
- For the group membership to take effect, the affected users have to log-out
- and log-in again.
+ For the group membership to take effect, the affected users have to logout
+ and login again.
Source: solaar
Section: misc
Priority: optional
Maintainer: Stephen Kitt <skitt@debian.org>
Build-Depends: debhelper (>= 9)
Build-Depends-Indep: python, po-debconf
X-Python-Version: >= 2.7
X-Python3-Version: >= 3.2
Standards-Version: 3.9.5
Homepage: http://pwr.github.io/Solaar
Vcs-Git: git://anonscm.debian.org/collab-maint/solaar.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/solaar.git

Package: solaar
Architecture: all
Depends: ${misc:Depends}, ${debconf:Depends}, udev (>= 175), passwd | adduser,
 ${python:Depends}, python-pyudev (>= 0.13), python-gi (>= 3.2), gir1.2-gtk-3.0 (>= 3.4),
 ${solaar:Desktop-Icon-Theme}
Recommends: gir1.2-notify-0.7, consolekit (>= 0.4.3) | systemd (>= 44),
 python-dbus (>= 1.1.0), upower
Suggests: gir1.2-appindicator3-0.1, solaar-gnome3 (= ${source:Version})
Description: Logitech Unifying Receiver peripherals manager for Linux
 Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
 It is able to pair/unpair devices to the receiver, and for some devices read
 battery status.

Package: solaar-gnome3
Architecture: all
Section: gnome
Depends: ${misc:Depends}, solaar (= ${source:Version}),
 gir1.2-appindicator3-0.1, gnome-shell (>= 3.4) | unity (>= 5.10),
 ${solaar:Gnome-Icon-Theme}
Enhances: solaar
Description: gnome-shell/Unity integration for Solaar
 Solaar is a Linux device manager for Logitech's Unifying Receiver peripherals.
 It is able to pair/unpair devices to the receiver, and for some devices read
 battery status.
 .
 This metapackage ensures integration with gnome-shell/Unity.

Attachment: signature.asc
Description: Digital signature


Reply to: