Re: [RFR] upgrade-advisor
Justin,
On Fri, 2008-11-07 at 08:43 +0000, Justin B Rye wrote:
> Franklin PIAT wrote:
> > Could someone review the texts in upgrade-advisor.
> > I've attached the POT and README file, but you can commit modify to the
> > git repository[1] directly (if you are in the collab-maint group)
>
> Sorry, I don't speak either po or VCS, but I'll do my best with the
> attached text.
It wasn't very nice of me to send this out like that...
FYI, If you want to retrieve the source, you need to install the package
"git-core". Then you can run
cd ~
git-clone git://git.debian.org/git/collab-maint/upgrade-advisor.git \
upgrade-advisor.git
Once you've finished the modification, run :
git-diff > ~/u-a.diff
And send the patch.
> > # SOME DESCRIPTIVE TITLE.
> > # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
> > # This file is distributed under the same license as the PACKAGE package.
> > # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
> > #
> > #, fuzzy
> > msgid ""
> > msgstr ""
> > "Project-Id-Version: PACKAGE VERSION\n"
> > "Report-Msgid-Bugs-To: \n"
> > "POT-Creation-Date: 2008-11-06 18:45+0100\n"
> > "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
> > "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
> > "Language-Team: LANGUAGE <LL@li.org>\n"
> > "MIME-Version: 1.0\n"
> > "Content-Type: text/plain; charset=CHARSET\n"
> > "Content-Transfer-Encoding: 8bit\n"
> >
> > #: ../upgrade-advisor.sh:49
> > msgid ""
> > " pre-upgrade Test the system prior the upgrade, then display hints\n"
> > " to ensure seemless upagrade.\n"
>
> " pre-upgrade Test the system prior to the upgrade, then display hints\n"
> " to ensure a seamless upgrade.\n"
ok.
> > " post-upgrade Test the system after the upgrade, then display hints\n"
> > " to get inline with freshly installed systems."
>
> Does this mean "then display hints for how to get online using the
> freshly installed system."?
A system that is upgraded to Lenny isn't identical to a freshly
installed system : Some configuration defaults are different, some
packages have been discontinued or replaced, etc..
post-upgrade list such differences.
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:56
> > #, sh-format
> > msgid "Usage: $PACKAGE_NAME"
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:57
> > msgid ""
> > " [pre-upgrade|post-upgrade] [options]\n"
> > "\n"
> > "A simple tool to print some hints before upgrading Debian.\n"
> > "\n"
> > "Command:"
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:63
> > msgid ""
> > "\n"
> > "Options:\n"
> > " -h, --help Print this message and exit\n"
> > " --version Print script version and exit\n"
> > " --verbose Verbose messages\n"
> > " --ignore-dist Continue (ignore) if distribution isn't supported."
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:84 ../upgrade-advisor.sh:86
> > msgid "--"
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:180
> > #, sh-format
> > msgid "Executable $x not found"
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:196
> > msgid "Can't download file. no download tool detected (wget or curl)."
> No
ok
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:289
> > msgid "Invalid argument specified for --output=..."
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:290
> > msgid "-n"
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:304
> > msgid "Invalid --debug argument: Function name expected (separated by commas)"
> > msgstr ""
>
> (What are the commas separating the function name from?)
Maybe something like :
"Invalid argument. --debug expects a comma separated list of plugin names."
(I used to expect a like of function names, but the behavior was
changed).
> > #: ../upgrade-advisor.sh:332
> > msgid "No command were specified. valid commands are:"
> was Valid
ok
> > msgstr ""
> >
> > #: ../upgrade-advisor.sh:334
> > #, sh-format
> > msgid "see $PACKAGE_NAME -h to get further help."
> > msgstr ""
> >
> > #: ../plugins/A-10_check_os:21
> > msgid "Incorrect OS distribution familly."
> family
ok
> > msgstr ""
> >
> > #: ../plugins/A-10_check_os:23
> > msgid "The file /etc/debian_version is not detected"
> was
>
> (Or: "No /etc/debian_version file detected")
I get your suggestion.
> > msgstr ""
> >
> > #: ../plugins/A-10_check_os:52
> > msgid "Incorrect distribution version."
> > msgstr ""
> >
> > #: ../plugins/A-10_check_os:84
> > msgid "Checking Operating System."
> > msgstr ""
> >
> > #: ../plugins/A-20_check_update_grub_path:5
> > msgid "Checking update-grub path in /etc/kernel-img.conf"
> > msgstr ""
> >
> > #: ../plugins/A-20_check_update_grub_path:8
> > msgid "The path to update-grub in /etc/kernel-img.conf is wrong."
> > msgstr ""
> >
> > #: ../plugins/A-20_etc_network_options_deprecated:5
> > msgid "Checking /etc/network/options migrated."
>
> Maybe "Checking /etc/network/options has been migrated."?
ok
> > msgstr ""
> >
> > #: ../plugins/A-20_etc_network_options_deprecated:8
> > msgid ""
> > "The content of /etc/network/options should be migrated to /etc/sysctl.conf."
> > msgstr ""
> >
> > #: ../plugins/A-50_upgrade_to_rsyslog:6
> > msgid "Check packages klogd and sysklogd were upgraded to rsyslog."
> > msgstr ""
> >
> > #: ../plugins/A-50_upgrade_to_rsyslog:9
> > msgid "ToDo: Install rsyslog, the new default syslog daemon."
> > msgstr ""
> >
> > #: ../plugins/B-10_check_dpkg_audit:6
> > msgid "Checking partially installed packages."
> > msgstr ""
> >
> > #: ../plugins/B-10_check_dpkg_audit:11
> > msgid "Some partially installed packages require attention:"
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:7
> > msgid "Checking /etc/apt.sources"
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:18
> > msgid "The file /etc/apt/sources.list doesn't contains security entries."
>
> That's "doesn't contain", or perhaps "contains no security entries."
I take the second option.
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:19
> > msgid "Make sure you have up-to-date security updates installed."
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:24
> > msgid ""
> > "The file /etc/apt/sources.list contains entries that are NOT recommended:"
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:26
> > msgid "Debian Release Notes, paragraph 'Unofficial sources and backports'"
> ^see
ok
> > msgstr ""
> >
> > #: ../plugins/B-15_check_apt_sources:27
> > msgid "and 'Checking system status' regarding third-party packages."
> > msgstr ""
> >
> > #: ../plugins/B-25_dump_pkg_list:8
> > msgid "Retrieving installed packages data (this can take a while)."
>
> "Retrieving data for installed packages (this may take a while)."
ok
> > msgstr ""
> >
> > #: ../plugins/B-35_check_discontinued_packages:6
> > msgid "Check discontinued package, in next release."
>
> "Checking for packages discontinued in the new release."
>
> (Assuming "discontinued" means "no longer available"; this isn't an
> established usage, but it makes sense.)
I've rephrased as "Checking for packages no longer available in next
release."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_discontinued_packages:18
> > msgid "Check discontinued package in next release : Test skipped."
> ^ ^
> Ditto, plus ": test skipped.", without the extra space or
> capitalisation.
Damn it, I did that again ;(
> > msgstr ""
> >
> > #: ../plugins/B-35_check_etc_apt_preferences:4
> > msgid "Checking /etc/apt/preferences (APT pinning)."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_etc_apt_preferences:7
> > msgid "APT Pinning should be disabled."
> pinning
ok
> > msgstr ""
> >
> > #: ../plugins/B-35_check_nonfree_contrib:7
> > msgid "Check contrib and non-free packages, since last release."
>
> What does this mean? Something like "Checking changes in contrib
> and non-free packages since last release."?
"Checking for installed contrib and non-free packages."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_nonfree_contrib:10
> > msgid "The following contrib or non-free packages were found."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_obsolete_packages:5
> > msgid "Checking installed packages, for obsolete packages."
> ^
> Again, drop the comma.
ok
> > msgstr ""
> >
> > #: ../plugins/B-35_check_obsolete_packages:9
> > msgid "Obsolete and Locally Created Packages should be removed."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_obsolete_packages:10
> > #: ../plugins/B-35_check_orphan_packages:9
> > msgid "Debian Release Notes, paragraph 'Obsolete packages' :"
> ^
> Again, no space before a colon.
damn me !
> > msgstr ""
> >
> > #: ../plugins/B-35_check_orphan_packages:4
> > msgid "Checking installed packages, for orphan packages."
> ^ ^^^^^^
>
> (Reads following message) Oh, wait, this is "orphan" in the woefully
> misleading deborphan/debfoster sense?
yes
> Those aren't "orphans" in the normal non-Debian sense of being stray
> dependents with nobody to provide for them; and nor have they been
> "orphaned", in the specialised Debian QA sense of being packages with
> no maintainer to look after them.
I had the same feeling.
> If anything it's exactly the reverse of the normal English sense of
> the word "orphan": they're packages (such as libraries) that nothing
> else _depends_ on. So please don't call them "orphans"!
>
> So what should they be called? Well, I don't really know.
> Dependentless packages? Pointless packages? Ideally we'd use
> whatever term aptitude(8) or apt-get(8) use to describe this
> functionality, but there doesn't seem to be one. Assuming this is
> in fact a "deborphan" run, not a "deborphan -a", I'd suggest:
>
> "Checking installed packages for stray libraries."
"stray" isn't very common for non-native English speakers.
I've written this, but... it's odd.
"Checking installed packages for deborphan'ed libraries."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_orphan_packages:8
> > msgid "The following 'Orphaned Packages' have been reported by deborphan."
>
> "Deborphan reports the following packages are 'orphans' (stray libraries):
>
> If it's going to be followed by a list, replace the period with a
> colon.
;)
> Doing the sentence this way round it's easier to deduce that it
> means "orphans in the inside-out deborphan sense", but really
> instead of using the wrong word and explaining it it's simpler to
> say:
> "Deborphan reports the following stray libraries:"
I use this one.
> > msgstr ""
> >
> > #: ../plugins/B-35_check_orphan_packages:15
> > msgid "Deborphan not installed. SKIPPED."
> > msgstr ""
> >
> > #: ../plugins/B-35_check_packages_status:4
> > msgid "Checking packages status."
>
> "Checking status of packages."
ok
> > msgstr ""
> >
> > #: ../plugins/B-35_check_packages_status:7
> > msgid "Packages in invalid state."
>
> (?) "Packages in an invalid state."
ok
> > msgstr ""
> >
> > #: ../plugins/B-35_check_packages_status:14
> > msgid "Packages on hold, in aptitude."
> ^
> > msgstr ""
> >
> > #: ../plugins/B-35_check_packages_status:24
> > msgid "Packages on hold, in dpkg and apt-get."
> ^
> > msgstr ""
> >
> > #: ../plugins/B-40_check_hypervisor:4
> > msgid "Checking Hypervisor."
>
> (?) "Checking for Xen hypervisor."
>
> (xen.org capitalises it thus.)
There could be some other hypervisor. I've written:
"Checking for hypervisor."
> > msgstr ""
> >
> > #: ../plugins/B-40_check_hypervisor:10
> > msgid "The XEN hypervisor was detected."
>
> (?) "A Xen hypervisor was detected."
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_hypervisor:12
> > msgid "It usually requires special steps to upgrade the kernel."
> > msgstr ""
> >
> > #: ../plugins/B-40_check_hypervisor:13 ../plugins/B-40_check_hypervisor:21
> > #: ../plugins/B-40_check_kernel:33
> > msgid "Verify kernel availablability/compatibility before upgrade."
> availability
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_hypervisor:20
> > msgid "It may require additional configuration steps."
>
> (?) This
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_kernel:5
> > msgid "Linux kernel 2.4 isn't supported anymore."
> any more
> Or more formally:
> "Linux kernel 2.4 is no longer supported."
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_kernel:23
> > msgid "Checking kernel and related packages."
> > msgstr ""
> >
> > #: ../plugins/B-40_check_kernel:26
> > msgid "Skipping kernel tests: Could not detect the kernel type."
> could
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_kernel:32
> > msgid "Skipping kernel tests: This tool don't support the current kernel."
> this doesn't
ok
> > msgstr ""
> >
> > #: ../plugins/B-40_check_udev:4
> > msgid "Checking /dev filesystem."
> > msgstr ""
> >
> > #: ../plugins/B-40_check_udev:8
> > msgid ""
> > "The /dev is using defvs. This option is now unsuported. use udev instead."
>
> "/dev is using defvs. This is no longer supported; use udev instead."
>
> (Mind you, Debian Lenny does still work with neither...)
That's right.
The test specifically detect if devfs is used. I assume that people
using devfs will switch to udev.
Also, the program provides a link to the release notes:
http://www.klabs.be/~fpiat/linux/debian/proposals/2008-09-07_Upgrade_advisor/r-notes/ch-whats-new.en.html#kernel-udev
> > msgstr ""
> >
> > #: ../plugins/B-40_check_udev:9
> > msgid "Debian Release Notes, paragraph 'Converting from devfs' :"
> ^
> Surplus space before colon.
grrr, again!
> > msgstr ""
> >
> > #: ../plugins/B-40_check_udev:14
> > msgid "Couldn't detect if /dev is actually using udev. Check this manually."
> whether /dev currently uses udev.
> > msgstr ""
> >
> > #: ../plugins/B-70_check_aptitude:4
> > msgid "Checking the presence aptitude."
>
> for the presence of aptitude
> or for aptitude
Picked the first option.
> > msgstr ""
> >
> > #: ../plugins/B-70_check_aptitude:7
> > msgid "Aptitude is recommended for upgrade."
> > msgstr ""
> >
> > #: ../plugins/B-70_check_aptitude:8
> > msgid "Debian Release Notes, paragraph 'Upgrading packages' :"
> ^
yeah...
> > msgstr ""
>
> And the README:
> > upgrade-advisor
> > ===============
> >
> > upgrade-advisor is a modular tool that makes recommendations and/or
> > print warnings for distribution upgrade.
> prints upgrades.
> >
> > It is complementary to the Releases-Notes[1], not a replacement (RTFM).
> >
> > Before upgrading
> > ----------------
> >
> > You simply invoke `upgrade-advisor pre-upgrade`. This will perform two
> > series of test :
>
> Simply invoke 'upgrade-advisor pre-upgrade'. This will perform
> two batteries of tests:
>
> Backticks imply that I invoke whatever this command says on STDOUT.
>
> Dictionaries do indeed say that the plural of "series" is "series",
> but I've never heard this used in spoken English without at least a
> hesitation; I habitually avoid the issue.
Interesting... I might have dropped the 's' for "one series" !
> > 1. Report post-upgrade recommendations from the previous upgrade. Like
>
> "The previous upgrade" suggests what is (I assume) the wrong model -
> one where upgrade-advisor has an idea of what counts as the
> "current" upgrade (Etch->Lenny), and this is a set of
> recommendations you can get for the "previous" one instead
> (Sarge->Etch), regardless of what your machine's currently running.
Yes, that's what I meant.
> 1. Report post-upgrade recommendations for a previously performed
> upgrade, such as
Exactly.
> > detecting wrong path to update-grub in /etc/kernel-img.conf (for
> ^the
> > systems that were upgraded from Sarge to Etch).
> > 2. Perform various pre-upgrade test. Currently, it especially focuses on
> > warning for discontinued packages.
> > But the long term goal is test all potential issues listed in the
> > Release Notes[1]
>
> 2. Perform various pre-upgrade tests. At present it focuses particularly
> on warnings for packages that are no longer available, but the long
> term goal is to test all the potential issues listed in the Release
> Notes[1].
>
> > After upgrading
> > ---------------
> >
> > You simply invoke `upgrade-advisor post-upgrade`. This will perform some
> > tests to ensure that steps listed in "Preparing for the next release" of
> > the Release-Notes[1] are completed.
>
> Simply invoke 'upgrade-advisor post-upgrade'. This will perform some
> tests to ensure that the steps listed in the Release Notes[1] under
> "Preparing for the next release" have been completed.
ok
> > Writing a plug-in / Adding a test
>
> Writing a plug-in/Adding a test
ok
> (Though it seems less definitely compulsory in a context like this.)
>
> > --------------------------------
> >
> > Read the README file in the plug-ins directory.
>
> (Where is the plug-ins directory?)
>
> > [1] http://www.debian.org/releases/stable/i386/release-notes/
>
> Assuming I run i386, that is.
I've replaced the footer with :
| Read the README file in the plug-ins directory. (in
| /usr/share/upgrade-advisor/plugins/)
|
|[1] Release Notes (this link is for i386 architecture)
| http://www.debian.org/releases/stable/i386/release-notes/
Thanks a lot for reviewing this text,
Regards,
Franklin
Reply to: