Bug#270326: kernel-image-2.6.8-powerpc: bad commandline default: root=/dev/sda2
On Wed, Sep 08, 2004 at 08:28:52AM +0200, Jens Schmalzing wrote:
> Hi,
>
> Sven Luther writes:
>
> > Can you check with giving the root device explicitly with : -r root when
> > creating the initrd ?
>
> Same thing. This is because the -r flag is only used for figuring out
> the necessary modules.
Ah, ok.
> > Also, if the same problems happens in d-i when you don't specifify
> > root=/dev/ram0, and you don't have root=/dev/sda2 as default command
> > line, then it is also a bug in d-i.
>
> #268986, to be precise.
>
> > Yeah, and you probably broke all other boxes out there who don't
> > mirror *your* PReP box setup,
>
> I like to think of it as having fixed all PReP boxen that do have the
> root filesystem on the second partition of the first SCSI disk. As
> well as having provided a clue to unsuspecting users what that prompt
> is for in the first place.
Was it not you who admonished me of doing stuff with the package for my own
convenience over the marvell patch ?
> > not to speak the unexplored repercussion on pmac/chrp boxes, now
> > that i have fixed the chrp default command line handling.
>
> Then maybe you should back out your patch and explore its implications.
Well, no, why ? The patch is a correct fix, which makes the default command
line work, Do you seriously think it is better to have a broken default
commandline on chrp/pmac, so that you can do your hacky workaround ?
I also submitted this upstream (well to linuxppc-dev), and the linuxppc guys
on irc told me to fix it, so ...
> > The right thing is to fix mkinitrd and not to break everyones
> > capacity of booting without root= argument.
>
> AFAICT, this capacity wasn't there in the first place.
Sure it was, when i boot a 2.6.8 kernel with initrd on my pegasos, it finds
the root filesystem all by itself, and on two boxes with root on different
places, and even with more than one potential root in it. I have not yet
tested this since your changes though, will do once i get time. This is an
initrd magic, since when i built a selfbuilt non-initrd kernel, it doesn't
find the root filesystem.
Friendly,
Sven Luther
Reply to: