Re: Xonotic: gmqcc package review

[Juhani Numminen <juhaninumminen0@gmail.com>]

Hi Anton,

In addition to Boris’ notes here are my suggestions.

How is the orig tarball (i.e. gmqcc_0.2-678-g100eaf9.orig.tar.gz)
created? What are the commands? If you have a local pristine-tar branch, please push it.

> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/docs;hb=HEAD
No need to have LICENSE there. Please read Lintian warnings, this is
catched by it:
W: gmqcc: extra-license-file usr/share/doc/gmqcc/LICENSE

> http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git;a=blob;f=debian/control;hb=HEAD
Again, lintian has something to say:
I: gmqcc source: vcs-field-not-canonical http://git.debian.org/?p=pkg-games/gmqcc.git
   http://anonscm.debian.org/gitweb/?p=pkg-games/gmqcc.git
I: gmqcc source: vcs-field-not-canonical git://git.debian.org/pkg-games/gmqcc.git
   git://anonscm.debian.org/pkg-games/gmqcc.git


Thanks for your work,
--
Juhani Numminen