Hi!
Two months later… Here's another attempt to have the partitioning screen
looking nice on the graphical installer. :)
On Tue, Apr 01, 2008 at 05:49:49AM +0200, Frans Pop wrote:
> > * Loosing right-alignment for the partition numbers (#3) and size
> > (100 GB).
> [...]
> > Of course, we could support right-alignment only in the text and newt
> > frontend for now, and silently discard the directive when using GTK+…
>
> I think that would be worthwhile as for these interfaces it is a usability
> regression. For gtk it's not really as the alignment in general is
> improved.
Good news: I have found ways to implement center and right alignment in
the text, newt AND GTK+ frontends! :) So this regression is history.
We could even center other options in the partitioning screens if we'd
like to. [1]
[1] An example:
http://people.debian.org/~lunar/cdebconf-align-center+right.png
> It should be tested before we commit this. I would consider regressions in
> preseeding of partitioning to be grave bugs.
I have made some preseeding tests with the given patch:
* Work fine:
d-i partman-auto/init_automatically_partition \
select Guided - use entire disk
d-i partman-auto/init_automatically_partition select some_device
d-i partman-auto/choose_recipe select Separate /home partition
d-i partman-auto/choose_recipe select home
* Don't work (as before):
d-i partman-auto/init_automatically_partition select regular
If we feel the last one is desirable, it's just a matter of adding an
extra test in debconf_select().
Comments on the attached patch set are welcome, as usual. :)
cdebconf/debian/changelog | 14 +
cdebconf/.../gtk/align_text_renderer.c | 106 +++++++++-
cdebconf/.../gtk/align_text_renderer.h | 7
cdebconf/.../gtk/cdebconf_gtk.c | 7
cdebconf/.../gtk/select_handlers.c | 81 ++++---
cdebconf/.../newt/newt.c | 15 -
cdebconf/.../text/text.c | 13 -
cdebconf/src/strutl.c | 66 +++++-
cdebconf/src/strutl.h | 5
cdebconf/src/test/align.config | 12 +
cdebconf/src/test/align.templates | 16 +
installer/doc/devel/partman/partman-doc.sgml | 6
partman-auto/debian/changelog | 8
partman-auto/debian/control | 2
partman-auto/debian/partman-auto.templates | 12 -
partman-base/Makefile | 7
partman-base/debian/changelog | 22 ++
partman-base/debian/control | 2
partman-base/debian/partman-base.install | 2
partman-base/debian/partman-base.templates | 12 -
partman-base/debian/rules | 2
partman-base/lib/base.sh | 67 +++++-
partman-base/partman | 15 -
partman-base/stralign.c | 41 ---
partman-base/update.d/visual | 16 -
partman-base/valid_visuals.d/_numbers | 9
partman-base/valid_visuals.d/bootable | 3
partman-base/valid_visuals.d/filesystem | 3
partman-base/valid_visuals.d/method | 3
partman-base/valid_visuals.d/mountpoint | 3
partman-base/valid_visuals.d/name | 11 -
partman-base/valid_visuals.d/number | 3
partman-base/valid_visuals.d/parted_fs | 3
partman-base/valid_visuals.d/size | 3
partman-base/valid_visuals.d/type | 11 -
partman-base/visual.d/_numbers | 9
partman-base/visual.d/bootable | 4
partman-base/visual.d/filesystem | 6
partman-base/visual.d/indent | 3
partman-base/visual.d/method | 10
partman-base/visual.d/mountpoint | 6
partman-base/visual.d/name | 8
partman-base/visual.d/number | 7
partman-base/visual.d/parted_fs | 19 -
partman-base/visual.d/size | 2
partman-base/visual.d/type | 11 -
partman-basicfilesystems/.../basicfilesystems/choices | 24 --
partman-basicfilesystems/debian/changelog | 7
partman-basicmethods/active_partition/format/choices | 3
partman-basicmethods/debian/changelog | 5
partman-crypto/active_partition/cipher/choices | 3
partman-crypto/active_partition/crypto_type/choices | 3
partman-crypto/active_partition/erase/choices | 3
partman-crypto/debian/changelog | 9
partman-crypto/debian/control | 2
partman-crypto/debian/partman-crypto.templates | 15 -
partman-crypto/lib/crypto-base.sh | 10
partman-ext2r0/active_partition/ext2r0/choices | 9
partman-ext2r0/debian/changelog | 6
partman-ext2r0/debian/control | 2
partman-ext3/active_partition/ext3/choices | 15 -
partman-ext3/debian/changelog | 7
partman-ext3/debian/control | 2
partman-jfs/active_partition/jfs/choices | 9
partman-jfs/debian/changelog | 8
partman-jfs/debian/control | 2
partman-lvm/choose_partition/lvm/do_option | 4
partman-lvm/debian/changelog | 7
partman-lvm/debian/control | 2
partman-partitioning/.../change_name/choices | 3
partman-partitioning/.../resize/choices | 1
partman-partitioning/.../toggle_bootable/choices | 6
partman-partitioning/debian/changelog | 9
partman-partitioning/...partman-partitioning.templates| 9
partman-partitioning/lib/disk-label.sh | 6
partman-reiserfs/active_partition/reiserfs/choices | 9
partman-reiserfs/debian/changelog | 8
partman-reiserfs/debian/control | 2
partman-target/active_partition/method/choices | 3
partman-target/debian/changelog | 9
partman-target/debian/partman-target.templates | 3
partman-xfs/active_partition/xfs/choices | 9
partman-xfs/debian/changelog | 7
partman-xfs/debian/control | 2
82 files changed, 578 insertions(+), 297 deletions(-)
Cheers,
--
Jérémy Bobbio .''`.
lunar@debian.org : :Ⓐ : # apt-get install anarchism
`. `'`
`-
Attachment:
partman_align_v2.diff.gz
Description: Binary data
Attachment:
signature.asc
Description: Digital signature