Bug#63804: Cannot select module when two modules have prefix >= 15 chars.

[Peter Muir <muirp@ieels.com>]

Package: modconf
Version: 0.2.26.14
Severity: wishlist
Linux peter 2.2.14 #1 SMP Mon May 8 09:49:28 MDT 2000 i586 unknown

I installed alsa-driver. There are two drivers in there that have very
long identical prefixes (17 characters):

bash-2.04$ ls /lib/modules/2.2.14/sound/snd-card-opt*
/lib/modules/2.2.14/sound/snd-card-opti92x-ad1848.o
/lib/modules/2.2.14/sound/snd-card-opti92x-cs4231.o
/lib/modules/2.2.14/sound/snd-card-opti93x.o
bash-2.04$ 

When using modconf and whiptail, I found out whiptail creates
two columns from the tag and titles of all the menu options. It makes
the first column equal to the longest of the tags.
There must be a space at the beginning of the title (or whiptail does
not work). However one can see that if two menu items have the same
prefix then the tag will allow both names (by glob) to be passed to
the modprobe.

I have no solution of course. I thought you might use the first column
for tag and title and the second column only for + or -. Then you
would have to snip off the comment from the tag returned by
whiptail. Or else whiptail might be improved.

Ciao, Peter Muir

Attached: My patch simply removes the truncation of the tag. I also
shorten one of the messages because it gets chopped off.

cd /home/muirp/debian/
cvs rdiff -r debian_version_0_2_26_14 -r debian_version_0_2_26_14_1 debian/modconf
cvs rdiff: Diffing debian/modconf
cvs rdiff: Diffing debian/modconf/debian
Index: debian/modconf/debian/changelog
diff -c debian/modconf/debian/changelog:1.1.1.1 debian/modconf/debian/changelog:1.2
*** debian/modconf/debian/changelog:1.1.1.1	Sun Apr 23 13:33:01 2000
--- debian/modconf/debian/changelog	Tue May  9 00:11:07 2000
***************
*** 1,3 ****
--- 1,9 ----
+ modconf (0.2.26.14.1) unstable; urgency=low
+ 
+   * Because of long module names, do not truncate.
+ 
+  -- Peter Muir <muirp@ieels.com>  Mon,  8 May 2000 13:04:45 -0600
+ 
  modconf (0.2.26.14) frozen unstable; urgency=low
  
    * Thanks to Dan Jacobowitz <dan@debian.org> for pointing out a serious
cvs rdiff: Diffing debian/modconf/modules
Index: debian/modconf/modules/util
diff -c debian/modconf/modules/util:1.1.1.1 debian/modconf/modules/util:1.2
*** debian/modconf/modules/util:1.1.1.1	Sun Apr 23 14:12:21 2000
--- debian/modconf/modules/util	Tue May  9 00:13:27 2000
***************
*** 139,145 ****
        fi
  
        echo -n \"
!       echo -n $module |$sed -e 's/^\(...............\).*$/\1/'
        echo -n \" \"$selected" "
        module_summary $module
        echo \" \\
--- 139,145 ----
        fi
  
        echo -n \"
!       echo -n $module
        echo -n \" \"$selected" "
        module_summary $module
        echo \" \\
cvs rdiff: Diffing debian/modconf/template
Index: debian/modconf/template/eval_C.fixed
diff -c debian/modconf/template/eval_C.fixed:1.1.1.1 debian/modconf/template/eval_C.fixed:1.2
*** debian/modconf/template/eval_C.fixed:1.1.1.1	Sat Jan 29 14:21:55 2000
--- debian/modconf/template/eval_C.fixed	Tue May  9 00:13:43 2000
***************
*** 1,5 ****
  # Descriptions must nor exceed a line!
! # Descriptions must not exeed 55 characters!
  # substitute `+', `-' and `,' in module names with `_'
  
  msg_Something_went_wrong="Something went wrong. You might want to write down the error messages
--- 1,5 ----
  # Descriptions must nor exceed a line!
! # Descriptions must not exeed 50 characters!
  # substitute `+', `-' and `,' in module names with `_'
  
  msg_Something_went_wrong="Something went wrong. You might want to write down the error messages
***************
*** 7,13 ****
  msg_Cant_make_temfile="Can't make temporary file for dialog box."
  msg_Desc_not_avail="(No description available)"
  msg_Exit="Exit"
! msg_Finished_these="Finished with these modules. Return to previous menu."
  msg_Please_wait_l="Please wait while modules are detected."
  msg_Please_wait="Please wait"
  msg_module_not_installed="The \$module module is not currently installed."
--- 7,13 ----
  msg_Cant_make_temfile="Can't make temporary file for dialog box."
  msg_Desc_not_avail="(No description available)"
  msg_Exit="Exit"
! msg_Finished_these="Finished here. Return to previous menu."
  msg_Please_wait_l="Please wait while modules are detected."
  msg_Please_wait="Please wait"
  msg_module_not_installed="The \$module module is not currently installed."

Compilation finished at Tue May  9 00:15:57