Control: tags -1 +moreinfo
Hi,
Here's the review like I mentioned in #debian-python
Firstly I highly recommend you to move your repository to Debian Salsa
under Debian Python Team to make it easier for your sponsors to make any
fixes. Github makes it difficult to work with.
In debian/rules,
export PYBUILD_NAME = random-quote
It should be renamed to whatever package that your package is
installing, in this case it is eventdispatch
You're also missing d/upstream/metadata, please refer to one of my
metadata files for reference [1] and add it back
Your d/changelog is also in the wrong format
Versioning of the package must be the same as upstream. For example, if
the upstream version is 3.4.0, the debian package version should be
3.4.0-1 and once your package gets uploaded to debian but you need some
fixes in the debian folder, you make a new update for 3.4.0-2.
Your d/changelog also needs to close the ITP bug, refer to this [2] for
example
I cannot go any deeper than this as the entire packaging is riddled with
errors. Consider using sbuild to build your packages as it makes it
easier to detect lintian errors. Using dh_make will generate a pre-made
debian folder template for you that you can easily edit.
https://mentors.debian.net/package/python-eventdispatch/
Also a lot of errors reported by Debian QA on mentors. Refer to the
debian docs and I recommend going for a fresh packaging with the tools I
mentioned as this one is entirely messed up.
Remove the moreinfo tag using "Control: tags -1 -moreinfo" once you fix
all of the errors.
To give you a better idea of what a python library debian folder should
look like, have a look at one of my recent packages [3].
[1]
https://salsa.debian.org/python-team/packages/python-resample/-/blob/debian/latest/debian/upstream/metadata?ref_type=heads
[2]
https://salsa.debian.org/python-team/packages/python-resample/-/blob/debian/latest/debian/changelog?ref_type=heads
[3]
https://salsa.debian.org/python-team/packages/python-resample/-/tree/debian/latest/debian?ref_type=heads
--
Regards,
Aryan Karamtoth
Matrix: @SpaciousCoder78:matrix.org
XMPP: SpaciousCoder78@xmpp.earth
GPG Fingerprint: 7A7D 9308 2BD1 9BAF A83B 7E34 FE90 07B8 ED64 0421