[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1115074: RFS: sane-backends/1.4.0-1 -- API library for scanners



Hi Jörg,

Thanks for packaging the new sane-backends upstream!

Apologies for not replying quicker, before you did another mentors
upload - I was originally hoping to do some more general testing to give
you more useful real world feedback before replying.

On Sat, Sep 13, 2025 at 06:13:22PM +0200, Jörg Frings-Fürst wrote:
> It's uploaded to mentors and into git.

I have a suggestion for this or a future upload to the archive. Would
you consider (a) disabling the initscript by default so the behaviour
matches the systemd experience, and (b) adding --no-start in both cases
as I don't think there's any point in starting the service on
installation but not on reboot?

How about a change along the lines of this patch?

Andrew

diff --git a/sane-backends-1.4.0/debian/rules b/sane-backends-1.4.0+mod/debian/rules
index 1b0243f..79371c5 100755
--- a/sane-backends-1.4.0/debian/rules
+++ b/sane-backends-1.4.0+mod/debian/rules
@@ -148,11 +148,11 @@ ifeq (linux,$(DEB_HOST_ARCH_OS))
 endif
 
 override_dh_installinit-arch:
-       dh_installinit -psane-utils --name=saned
+       dh_installinit -psane-utils --no-enable --no-start --name=saned
 
 override_dh_installsystemd-arch:
-       dh_installsystemd -psane-utils --no-enable --name=saned
-       dh_installsystemd -psane-utils --no-enable --name=saned@
+       dh_installsystemd -psane-utils --no-enable --no-start --name=saned
+       dh_installsystemd -psane-utils --no-enable --no-start --name=saned@
 
 override_dh_makeshlibs-arch:
        dh_makeshlibs --exclude=/sane/ -- -v$(DEB_VERSION_UPSTREAM) -Pdebian/libsane1 -plibsane1


Reply to: