Control: tags -1 moreinfo
On Thu, 14 Aug 2025 21:06:18 -0400
"James Montgomery" <james@bitrefactory.com> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Hi mentors,
>
> I intend to adopt libbs2b (was orphaned; ITA closes #1007187).
hi James,
I granted you maintainer access to the package's repo, as that is
easier than dealing with MRs over multiple branches (master, upstream,
pristine-tar).
It seems that your update is pulling in on the latest git commit at
the fork on github. That makes it a fresh new upstream version, beyond
the actual 3.1.0 that is currently in Debian, which should be
reflected in the versioning of the packaging. Tracking the latest
commit can be automated via uscan and d/watch along the lines of:
'mode=git,pretty=3.1.0+git%cd,repacksuffix=+dfsg,dversionmangle=s/\+dfsg\d*$//'
...which would result in 3.1.0+git20141017+dfsg-1 in Debian. Please
update d/watch and then use 'gbp import-orig --uscan' to bump the
repo to that new upstream version.
Most of the changes to the packaging itself look sane to me at first
glance, in particular dropping the old get-orig-source target in
favour of a modern approach via d/copyright and the watch file.
Still have some questions and hints though:
* control: you could move the description into the source stanza and
then reference it via ${source:Extended-Description}, and avoid
having to repeat the identical text for every binary package. See
[1] for numerous examples.
* control: any reason for re-ordering the binary packages? It makes
the diff from the previous revision a lot harder to read.
* copyright: various entries were removed, including the one for the
Debian packaging itself. Why?
* rules: why the dh_auto_clean override? Builds should be done in a
clean environment anyway, such as sbuild or pbuilder.
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
[1]https://codesearch.debian.net/search?q=path%3Adebian%2Fcontrol%20%24%7Bsource%3AExtended-Description%7D&literal=1&perpkg=1
Attachment:
pgpDURbNQW2HO.pgp
Description: OpenPGP digital signature