Control: tags -1 = moreinfo
Hi Benoît,
Packaging looks good, just a few concerns.
- nice to have: add filenamemangle do d/watch
It would be nice to have d/watch look something like this:
version=4
opts="filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%@PACKAGE@-$1.tar.gz%" \
https://git.noise.rocks/ben/@PACKAGE@/tags .*/v?(\d.*)@ARCHIVE_EXT@
This allows the tarball to be downloaded to myosotis-0.1.0.tar.gz
rather than v0.1.0.tar.gz.
- nice to have: debian/gbp.conf
Adding a gbp.conf file that sets the correct branch names allows using
git-buildpackage[3] as well as other tools that check for this file.
See [4] for an example of this in a similar setup as yours (debian
branch in upstream's repo).
One of the things you can do with this is use gbp import-ref <tag>
rather than merge the main branch every time there is a new version.
- Vcs-* fields in d/control
For some reason these were removed in one of your commits. These
fields should be present so that tools like tracker.d.o can link to
the VCS.
- Metainfo file references wrong name for desktop file
data/myosotis.metainfo.xml.in contains:
<launchable type="desktop-id">myosotis.desktop</launchable>
Whereas the desktop file is actually called
rocks.noise.myosotis.desktop.
- Icon is non-free
In your README, it says that the icon is from Freepik. It appears
that the Freepik license terms[1] are not compliant with the DFSG[2]
as they place many restrictions on how the content is used. Icon needs
to either be changed or removed.
--
Maytham
[1] https://www.freepik.com/legal/terms-of-use#nav-freepik-agreement
[2] https://www.debian.org/social_contract#guidelines
[3] https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/
[4] https://codeberg.org/Maytha8/gophian/src/commit/48ee14f2b6077a48d07de05e077ee4fc59a45245/debian/gbp.conf
Attachment:
signature.asc
Description: This is a digitally signed message part