Bug#1092027: RFS: midiminder/1.0.1-1 [ITP] -- MIDI connection minder & viewer

[Hugh McMaster <hmc@debian.org>]

Control: owner -1|!|

Hi John,

Thanks for packaging midiminder.

On 4/01/2025 7:17 am, John Horigan wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "midiminder":
>
>   * Package name     : midiminder
>     Version          : 1.0.1-1
>     Upstream contact : Mark Lentczner <mark@glyphic.com>
>   * URL              :https://github.com/mzero/midiminder
>   * License          : BSD-2-clause
>   * Vcs              :https://github.com/mzero/midiminder
>     Section          : sound

You have done really well with this package. There are a few areas to 
polish before we can progress.

Running `debuild -us -uc -S` from the source tree and then `lintian 
-EviIL +pedantic` from the parent directory will yield some lintian 
warnings to fix. You can also see these on your package's Debian Mentors 
page.

d/changelog:

  * Remove trailing whitespace (blank line) on line 6.

  * Target 'experimental' for initial upload since we are in hard 
freeze. This means your package enters the NEW queue sooner. A 
source-only upload targeting 'unstable' will be needed anyway.

d/control: "easy to write" should be hyphenated as "easy-to-write".

d/copyright:

  * The BSD-2-clause and BSD-3-clause licences must be copied verbatim 
from the source package.

  * For BSD-2-clause, remove the version line, and fix the years of 
copyright. It is correct to specify 2020-2025 in the Files stanza above, 
however.

  * BSD-3-clause is quite different to the upstream version.

  * Please update your copyright for 2025 (i.e. 2024-2025).

  * Side note: in README.md you describe yourself as one of the 
authors, but you don't list yourself in any upstream copyright. Just 
wanting to check this with you.

d/manpages: Please sort the list.

d/postinst:

  suggest_package_removal amidiauto
  stop_and_disable_service amidiauto
  suggest_package_removal amidiminder
  stop_and_disable_service amidiminder
  advise_old_rules

  * None of these functions have any purpose on Debian. amidiauto and 
amidiminder are not in the repository, so we have no expectation that 
users will have these installed. In saying that, there's no practical 
impact.

BUILDING.md: I noticed you specify debhelper-compat (=13) as a build 
dependency. You should just use 'debhelper' (unversioned), since 
debhelper-compat isn't actually a package.

Let me know if you have any questions.

Hugh