[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1104198: RFS: golf/479-1 [ITP] -- programming language for web services



---- On Tue, 06 May 2025 13:06:56 -0700 Hilmar Preuße <hille42@web.de> wrote ---

On 05.05.25 01:17, Golf Team wrote:

Hello,

> Removed dh_dwz override, it was there because lintian said that
> compression isn't beneficial, but it doesn't break anything, so it
> should be fine.
>
Thanks for the changes for now. I don't really believe that lintian
complains about this, hence I rather tend to keep the dwz call.

Two further things, which came to my attention right now:

- is there a reason why you hard code -std=gnu99 in the Makefile?
- the package fails to compile using gcc 15 after -std=gnu99 has been
removed (did not check w/o removing). gcc-15 will be default compiler
shortly after releasing trixie. Dropping the compiler standard to
gnu99 is IMHO only a workaround.

The error message I got for now is, maybe there are more.

db.c:780:55: error: too many arguments to function ‘gg_maria_fieldname’;
expected 0, have 1
780 | (*col_names)[field_index] =
gg_strdup(gg_maria_fieldname(is_prep));
|
^~~~~~~~~~~~~~~~~~ ~~~~~~~
golf.h:1602:7: note: declared here
1602 | char *gg_maria_fieldname();
| ^~~~~~~~~~~~~~~~~~
db.c:788:55: error: too many arguments to function ‘gg_lite_fieldname’;
expected 0, have 1
788 | (*col_names)[field_index] =
gg_strdup(gg_lite_fieldname(field_index));
|
^~~~~~~~~~~~~~~~~ ~~~~~~~~~~~
golf.h:1582:7: note: declared here
1582 | char *gg_lite_fieldname();
| ^~~~~~~~~~~~~~~~~

Hilmar

--
Testmail


Hi Hilmar,

thanks for the feedback. 

-std=gnu99 was used when we transitioned from a pure C language framework to Golf (which is still a C framework, but it's now also its own language). It just stayed even after we fixed the issues.

-std=gnu99 is now removed.

I installed gcc 15 from debian experimental and fixed the issues. Golf now compiles and test cleanly. Of course, it does so still for previous gcc version.

The new version with these changes is 520, which is both on Mentors as well as Salsa.

Best,
Sergio
 


Reply to: