Bug#1100055: RFS: sanlock/3.9.5-1 -- Shared storage lock manager
Control: tags -1 -moreinfo
On 12.03.2025 09:56, Phil Wyett wrote:
> Control: tags -1 +moreinfo
>
> Havard,
>
> Review of upload: 2025-03-10 19:26
>
> For information about the tests run, see:
>
> https://wiki.debian.org/PhilWyett/DebianMentoring
>
> Test 3 (build twice): Information only
>
> dh clean
> dh_auto_clean
> make -j10 clean
> make[1]: Entering directory '/build/sanlock-3.9.5'
> for dir in wdmd src python; do \
> make -C $dir clean; \
> done
> make[2]: Entering directory '/build/sanlock-3.9.5/wdmd'
> rm -f *.o *.so *.so.* wdmd wdmd_client
> make[2]: Leaving directory '/build/sanlock-3.9.5/wdmd'
> make[2]: Entering directory '/build/sanlock-3.9.5/src'
> rm -f *.o *.so *.so.* sanlock libsanlock.so.1.0 libsanlock_client.so.1.0
> libsanlock.pc libsanlock_client.pc
> make[2]: Leaving directory '/build/sanlock-3.9.5/src'
> make[2]: Entering directory '/build/sanlock-3.9.5/python'
> rm -rf build
> make[2]: Leaving directory '/build/sanlock-3.9.5/python'
> make[1]: Leaving directory '/build/sanlock-3.9.5'
> dh_clean
> dpkg-source -b .
> dpkg-source: info: using options from sanlock-3.9.5/debian/source/options: --
> extend-diff-ignore=(^|/)*.egg-info/
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building sanlock using existing ./sanlock_3.9.5.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: error: cannot represent change to reset/sanlk-reset: binary file
> contents changed
> dpkg-source: error: add reset/sanlk-reset in debian/source/include-binaries if
> you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'reset/sanlk-reset' will not be
> represented in diff
> dpkg-source: error: cannot represent change to reset/sanlk-resetd: binary file
> contents changed
> dpkg-source: error: add reset/sanlk-resetd in debian/source/include-binaries if
> you want to store the modified binary in the debian tarball
> dpkg-source: warning: executable mode 0755 of 'reset/sanlk-resetd' will not be
> represented in diff
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 1
> I: copying local configuration
> E: Failed autobuilding of package
>
> Summary
> =======
>
> Havard, Looks good. You may wish to look at the failure of test 3?
>
> I would encourage adding Salsa CI to your package to ease development.
>
CI on Salsa has existed since August 2021.
Reply to: