Bug#1087484: RFS: wifi-qr/0.4-1 -- WiFi password share via QR codes

Control: tags -1 -moreinfo

Dear Maintainer,

Please find an updated version of the wifi-qr package (version 0.4).
This release includes Zenity and Kdialog support, external Webcam/WebCam selector support,
and an updated d/watch file with PGP signing.

Key changes in this update are:

* New upstream release (0.4)

* Extended debian/source ignore patterns to exclude README, Screenshots, and wifi-qr.spec

* Updated debian/copyright with a bumped copyright year to 2024 and the addition of wifi-qr.metainfo.xml with a CC0-1.0 license

* Updated debian/control to modify the dependency from zenity to "zenity | kdialog"

* Updated debian/watch with a new URL pattern for PGP asc

Thank you for your time and consideration.

https://mentors.debian.net/package/wifi-qr/

https://mentors.debian.net/debian/pool/main/w/wifi-qr/wifi-qr_0.4-1.dsc

d/changelog

  * New upstream release (0.4)
  * Extend debian/source ignore patterns
    - exclude README and Screenshots
    - exclude wifi-qr.spec
  * Update debian/copyright
    - Bump copyright year to 2024
    - Add wifi-qr.metainfo.xml with CC0-1.0 license
  * Update debian/control
    - Modify dependency from zenity to "zenity | kdialog"
  * Update debian/watch
    - Update url pattern for pgp asc.

Sincerely,

Ko Ko Ye

On Sat, Jan 11, 2025 at 7:36 AM Phil Wyett <philip.wyett@kathenas.org> wrote:

Control: tags -1 +moreinfo

Ko Ko Ye,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

* pbuilder [1]: Good
* sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Issue

philwyett@ks-tarkin:~/Development/builder/debian/wifi-qr-0.4$ uscan --force-
download
uscan warn: In directory ., downloading
https://github.com/kokoye2007/wifi-qr/archive/refs/tags/v0.4.tar.gz.asc
failed: 404 Not Found
uscan die: FAIL Checking OpenPGP signature (no signature file downloaded).

5. Build Twice (build source after successful build [1]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe 'wifi-qr' is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

To remove 'moreinfo' tag, add below line to top of email replying to bug report
when a new upload is made.

Control: tags -1 -moreinfo

Please try the below on your packages...

[1] pbuilder:

* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild

[3] lintian:

* Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
* Document: https://wiki.debian.org/Lintian

[4] lrc:

* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

Note: Please report false positives as bug reports against 'licenserecon'