Conrtrol: tags -1 +moreinfo
Kirill,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: xfce4-time-out-plugin: incorrect-locale-code hye -> hy
[usr/share/locale/hye/]
N:
N: The package appears to ship locales for a language but uses an incorrect
N: locale code as a subdirectory of /usr/share/locale. This usually results
N: in users of the intended target language not finding the locale. The
N: language codes used in the locale directories are those from the ISO 639-1
N: and ISO 639-2 standards, not those usually used as TLDs (which are from
N: the ISO 3166 standard).
N:
N: When both standards define a language code for a given language, the ISO
N: 639-1 code should be used (i.e. the two lettered code).
N:
N: Lintian only knows about some commonly-mistaken set of incorrect locale
N: codes.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: files/locales
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/xfce4-time-out-plugin-1.1.4$
lrc
en: Versions: recon 3.3 check 3.3.9-1
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | FSFULLR config.rpath
4. Watch file [uscan --force-download]: Good
5. Build Twice (build source after successful build [1]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Additional...
A. The changelog entry for a new package or new package version in Debian
should end with '-1'.
A new package needs one changelog entry that state initial release and closes
the Intent To Package (ITP) bug i.e. (Closes: #ITP_BUG_NUMBER)
B. I would encourage working with the XFCE Team. Under their umbrella I would
hope you would get a lot of help and advice. Collaboration works. :-)
Summary...
I believe 'xfce4-time-out-plugin' is not yet ready for sponsorship at this
time. Could the contributor rectify one of more of the raised issues.
Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.
To remove 'moreinfo' tag, add below line to top of email replying to bug report
when a new upload is made.
Control: tags -1 -moreinfo
Please try the below on your packages...
[1] pbuilder:
* Command for 1.: sudo pbuilder build <PACKAGE>.dsc
* Command for 5.: sudo pbuilder build --twice <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild -d unstable <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
Note: Please report false positives as bug reports against 'licenserecon'