[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1089633: RFS: adminerevo/4.8.4-1 [ITP] -- Web-based database administration tool



Control: tags -1 +moreinfo

Alexandre,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Information

Running lintian...
N:
I: adminerevo source: composer-package-without-pkg-php-tools-builddep
[composer.json]
N: 
N:   The package contains a composer.json file but doesn't build-depend on
N:   pkg-php-tools.
N:   
N:   pkg-php-tools is the recommended tool for building PHP Composer packages.
N:   For more information, install it and read the included README.Composer.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/php/pear
N: 
N:
I: adminerevo: package-contains-documentation-outside-usr-share-doc
[usr/share/adminerevo/plugins/drivers/readme.txt]
N: 
N:   This package ships a documentation file outside /usr/share/doc
N:   Documentation files are normally installed inside /usr/share/doc.
N:   
N:   If this file doesn't describe the contents or purpose of the directory it
N:   is in, please consider moving this file to /usr/share/doc/ or maybe even
N:   removing it. If this file does describe the contents or purpose of the
N:   directory it is in, please add a lintian override.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation
N: 
N:   Screen: python/egg/metadata
N:     Advocates: "Scott Kitterman" <debian@kitterman.com>
N:     Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N:             Python modules. Those files are not documentation even though
N:             some of their names carry the .txt file extension.
N:             
N:             Python modules can be both public and private.
N:             
N:             Read more in
N:            
https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N:             https://www.python.org/dev/peps/pep-0376/#id16,
N:             https://www.python.org/dev/peps/pep-0610/,
N:             https://www.python.org/dev/peps/pep-0639/,
N:            
https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N:             and Bug#1003913.
N: 
N:
I: adminerevo: package-contains-empty-directory
[usr/share/adminerevo/designs/hydra/]
N: 
N:   This package installs an empty directory. This might be intentional but
N:   it's normally a mistake. If it is intentional, add a Lintian override.
N:   
N:   If a package ships with or installs empty directories, you can remove them
N:   in debian/rules by calling:
N:   
N:    $ find path/to/base/dir -type d -empty -delete
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: files/empty-directories
N: 
N:
I: adminerevo: package-contains-empty-directory
[usr/share/adminerevo/designs/pepa-linha-dark/]
N:
P: adminerevo source: renamed-tag debian-watch-does-not-check-gpg-signature =>
debian-watch-does-not-check-openpgp-signature [debian/source/lintian-
overrides:1]
N: 
N:   The package has an override for a tag that was renamed. Lintian tag are
N:   sometime renamed in order to improve their name.
N:   
N:   Override file is dynamically translated by Lintian. Nevertheless please
N:   replace the old name by the new name.
N: 
N:   Visibility: pedantic
N:   Show-Always: yes
N:   Check: debian/lintian-overrides/mystery
N: 

I: Lintian run was successful.

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Issue

dpkg-deb: building package 'adminerevo' in '../adminerevo_4.8.4-1_all.deb'.
 dpkg-genbuildinfo -O../adminerevo_4.8.4-1_amd64.buildinfo
 dpkg-genchanges -O../adminerevo_4.8.4-1_amd64.changes
dpkg-genchanges: info: including full source code in upload
 dpkg-source --after-build .
dpkg-buildpackage: info: full upload (original source is included)
dpkg-genchanges: info: including full source code in upload
dpkg-buildpackage: info: source package adminerevo
dpkg-buildpackage: info: source version 4.8.4-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Alexandre Rossi <niol@zincube.net>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --before-build .
 debian/rules clean
dh clean --with apache2
   dh_auto_clean
	make -j22 clean
make[1]: Entering directory '/build/adminerevo-4.8.4'
rm \
  --recursive \
  --force \
  /build/adminerevo-4.8.4/adminer.php
make[1]: Leaving directory '/build/adminerevo-4.8.4'
   dh_clean
 dpkg-source -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building adminerevo using existing
./adminerevo_4.8.4.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: error: cannot represent change to externals/jush/jush:
dpkg-source: error:   new version is symlink to /usr/share/javascript/jush
dpkg-source: error:   old version is nonexistent
dpkg-source: error: unrepresentable changes to source
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255
I: copying local configuration
E: Failed autobuilding of package


6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe adminerevo is not yet ready for sponsorship at this time. Could the
contributor rectify one of more of the raised issues.

Once updated to your satisfaction and a new upload done, please remove the
'moreinfo' tag on the Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

Liberapay: https://liberapay.com/kathenas

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Matrix: #kathenas:matrix.org

Website: https://kathenas.org

Wiki: https://wiki.kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--












Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: