Control: tags -1 _+moreinfo Jing, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: I: postfixadmin source: composer-package-without-pkg-php-tools-builddep [composer.json] N: N: The package contains a composer.json file but doesn't build-depend on N: pkg-php-tools. N: N: pkg-php-tools is the recommended tool for building PHP Composer packages. N: For more information, install it and read the included README.Composer. N: N: Visibility: info N: Show-Always: no N: Check: languages/php/pear N: N: I: postfixadmin: ored-depends-on-obsolete-package Depends: mysql-client => default-mysql-client N: N: The package depends on an ORed group of packages which includes a package N: that has been superseded. N: N: Visibility: info N: Show-Always: no N: Check: fields/package-relations N: N: I: postfixadmin source: patch-not-forwarded-upstream [debian/patches/0001- db_credentials.patch] N: N: According to the DEP-3 headers, this patch has not been forwarded N: upstream. N: N: Please forward the patch and try to have it included in upstream's version N: control system. If the patch is not suitable for that, please mention N: not-needed in the Forwarded field of the patch header. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to N: the upstream sources (Section 4.3) in the Debian Policy Manual, and N: Bug#755153 for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: Renamed from: send-patch N: N: P: postfixadmin: example-unusual-interpreter python [usr/share/doc/postfixadmin/examples/import_users_from_csv.py] N: N: This package contains an example script for an interpreter that is not N: shipped in the package and is not known to Lintian. It is possible that N: there is a typo or the interpreter is not executable. N: N: Visibility: pedantic N: Show-Always: no N: Check: scripts N: N: P: postfixadmin source: maintainer-manual-page [debian/manpage/postfixadmin- cli.1] N: N: The maintainer keeps a manual page in ./debian. Please forward the manual N: page upstream and ask them to include in their version control system, and N: in their next release. N: N: If the manual page was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/manual-pages N: Renamed from: maintainer-manpage N: N: P: postfixadmin source: source-contains-prebuilt-javascript-object [public/css/bootstrap-3.4.1-dist/js/bootstrap-datetimepicker.min.js] N: N: The source tarball contains a prebuilt (minified) JavaScript object. They N: are usually left by mistake when generating the tarball by not cleaning N: the source directory first. You may want to report this as an upstream N: bug, in case there is no sign that this was intended. N: N: Visibility: pedantic N: Show-Always: no N: Check: files/source-missing N: N: P: postfixadmin source: source-contains-prebuilt-javascript-object [public/css/bootstrap-3.4.1-dist/js/bootstrap.min.js] N: P: postfixadmin source: source-contains-prebuilt-javascript-object [public/css/bootstrap-3.4.1-dist/js/moment-with-locales.min.js] N: P: postfixadmin source: source-contains-prebuilt-javascript-object [public/jquery-3.7.0.min.js] N: N: it does not need to be executable. we have /usr/bin/postfixadmin-cli O: postfixadmin: script-not-executable [usr/share/postfixadmin/scripts/postfixadmin-cli.php] N: N: This file starts with the #! sequence that marks interpreted scripts, but N: it is not executable. N: N: There has been some discussion to allow such files in paths other than N: /usr/bin but there was ultimately no broad support for it. N: N: Please refer to Bug#368792 for details. N: N: Visibility: warning N: Show-Always: no N: Check: scripts N: I: Lintian run was successful. 3. Licenses [4]: Issue philwyett@ks-tarkin:~/Development/builder/debian/postfixadmin-3.3.14$ lrc en: Versions: recon 3.1 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap.css GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap.css.map GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap.min.css GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap.min.css.map GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap-theme.css GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap-theme.css.map GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap-theme.min.css GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/css/bootstrap-theme.min.css.map GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/js/bootstrap.js GPL-2+ | Expat public/css/bootstrap-3.4.1- dist/js/bootstrap.min.js 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Not performed at this time 8. Upgrade [Over previous installs if any]: Not performed at this time Summary... I believe postfixadmin is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Wiki: https://wiki.kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
Attachment:
signature.asc
Description: This is a digitally signed message part