Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

[souravbhattacharya@tutamail.com]

Sorry a small typo in the code. I meant

"Are you saying it should be:

---
#!/usr/bin/make -f
export PYBUILD_NAME=nextdns

%:
dh $@ --buildsystem=pybuild
---
 
instead of:

---

#!/usr/bin/make -f
export PYBUILD_NAME=python-nextdns

%:
dh $@ --buildsystem=pybuild

---"


Regards,

Sourav

Oct 11, 2024, 20:57 by souravbhattacharya@tutamail.com:

> Greetings Jeroen,
>
> Please ignore my previous reply. I have applied a patch to setup.py and now the pipeline runs without fail.
> I'll file a bug or a pull request for the same as well. I thought it was a pipeline configuration mistake because there were no issues testing the package locally, of course I was wrong as you said. I'll take care of  CI errors before making an RFS from now on. 
>
> "* control: most teams require team packages to sit in their team
> repository. Have you contacted the LEGO team?" - I think the repo could be migrated to the team once uploaded. But I have contacted them as well, waiting for a reply.
>
> "* rules: pybuild name -if set at all- should be whatever is used to
> import the module in Python, i.e. "nextdns". - I think I didn't understand well. I just kept the file generated by dh_make. Are you saying it should be:
>
> ---
> #!/usr/bin/make -f
> export PYBUILD_NAME=python
>
> %:
> dh $@ --buildsystem=pybuild
> ---
>  
> instead of:
>
> ---
>
> #!/usr/bin/make -f
> export PYBUILD_NAME=python-nextdns
>
> %:
> dh $@ --buildsystem=pybuild
>
> ---
>
> Thanking you,
> Sourav
>
>
> Oct 11, 2024, 14:02 by jcfp@debian.org:
>
>> Control: tags -1 moreinfo
>>
>> On Fri, 11 Oct 2024 10:03:44 +0530
>> Sourav Bhattacharya <souravbhattacharya@tutamail.com> wrote:
>>
>>> I am looking for a sponsor for my package python-nextdns:
>>>
>>
>> hi again Sourav,
>>
>> nice to see the improvements made since yesterday's review. Couple of
>> issues remaining before I can upload the package:
>>
>> * control: most teams require team packages to sit in their team
>> repository. Have you contacted the LEGO team?
>>
>> * rules: pybuild name -if set at all- should be whatever is used to
>> import the module in Python, i.e. "nextdns".
>>
>> * CI failure (autopkgtest [1]) on the salsa repo indicates a serious
>> problem with the binary package (one or more missing dependencies).
>> Please make a habit of inspecting CI results prior to filing a
>> sponsorship request.
>>
>> That missing dependency is probably caused by an upstream mistake in
>> setup.py, which only mentions the aiohttp module in "install_requires"
>> while requirements.txt also lists the tenacity module (as it should,
>> given the latter gets imported in nextdns/__init__.py:12).
>>
>> Either add a patch for setup.py or manually add the missing
>> dependency to the binary package for now. Please also file a bug
>> about this with the upstream developer(s).
>>
>>
>> [1]https://salsa.debian.org/sxctic-54l/python-nextdns/-/jobs/6412294
>>
>
>