Bug#1079474: RFS: openscap/1.4.0+dfsg-1 -- libraries enabling integration of the SCAP line of standards - Documentation
Control: tags -1 -moreinfo
On 24.08.2024 09:18, Phil Wyett wrote:
> Control: tags -1 +moreinfo
>
> Havard,
>
> Preamble...
>
> Thank you for taking the time to prepare this package and your contribution
> to the Debian project.
>
> The review below is for assistance. This review is offered to help package
> submitters to Debian mentors inorder to improve their packages prior to
> possible sponsorship into Debian. There is no obligation on behalf of the
> submitter to make any alterations based upon information provided in the
> review.
>
> Review...
>
> 1. Build:
>
> * pbuilder [1]: Good
> * sbuild [2]: Good
>
> 2. Lintian [3]: Good
>
> 3. Licenses [4]: Issue
>
> In 'debian/copyright', make sure there is a space after 'License:' and before
> the license being referenced. You will see a drastic change in the output of
> 'lrc -t'.
>
Good catch, Still, looking through the output, I can only see false positives.
> 4. Watch file [uscan --force-download]: Good
>
> 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
>
> 6. Reproducible builds [5]: Good
>
> 7. Install [No previous installs]: Good
>
> 8. Upgrade [Over previous installs if any]: Good
>
> Summary...
>
> I believe openscap is not yet ready for sponsorship at this time. Could the
> contributor rectify one of more of the rasied issues. Once updated to your
> satisfaction and a new upload done, please remove the 'moreinfo' tag on the
> Request For Sponsorship (RFS) bug report.
>
> Regards
>
> Phil
>
> [1] pbuilder:
>
> * Command: sudo pbuilder build <PACKAGE>.dsc
> * Document: https://wiki.ubuntu.com/PbuilderHowto.
> * Document: https://wiki.debian.org/PbuilderTricks
>
> [2] sbuild:
>
> * Command: sbuild <PACKAGE>.dsc
> * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
> * Document: https://wiki.debian.org/sbuild
>
> [3] lintian:
>
> * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
> *.changes, *.buildinfo). Each can throw up different results, so be thorough.
> * Document: https://wiki.debian.org/Lintian
>
> [4] lrc:
>
> * Command: lrc -t
> * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
>
> [5] reprotest
>
> * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
> build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
> * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
> * Document: https://wiki.debian.org/ReproducibleBuilds/
> * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
>
Reply to: