Control: tags -1 +moreinfo Christopher, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue I: blueman: desktop-entry-lacks-keywords-entry [usr/share/applications/blueman-manager.desktop] N: N: This .desktop file is either missing a Keywords entry, or it does not N: contain keywords above and beyond those already present in the Name or N: GenericName entries. N: N: The Keywords field is intended to show keywords relevant for a .desktop N: file. N: N: Desktop files are organized in key-value pairs and are similar to INI N: files. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html , N: Bug#693918, and N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for N: details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format I: blueman: systemd-service-file-missing-documentation-key [usr/lib/systemd/system/blueman-mechanism.service] N: N: The systemd service file does not contain a Documentation key. N: N: Documentation for systemd service files can be automatically viewed using N: systemctl help servicename if this field is present. N: N: Please refer to the systemd.unit(5) manual page for details. N: N: Visibility: info N: Show-Always: no N: Check: systemd I: blueman: unused-override no-manual-page [usr/libexec/blueman-mechanism] [usr/share/lintian/overrides/blueman:3] N: N: Your package specifies the named override but there were no tags that N: could have been silenced by it. N: N: Maybe you fixed an underlying condition but forgot to remove the override. N: It is also possible that the Lintian maintainers fixed a false positive. N: N: If the override is now unused, please remove it. N: N: This tag is similar to mismatched-override except there a tag could have N: been silenced if the context had matched. N: N: Sometimes, overrides end up not being used because a tag appears only on N: some architectures. In that case, overrides can be equipped with an N: architecture qualifier. N: N: Please refer to Architecture specific overrides (Section 2.4.3) in the N: Lintian User's Manual for details. N: N: Visibility: info N: Show-Always: yes N: Check: lintian I: blueman: unused-override no-manual-page [usr/libexec/blueman-rfcomm- watcher] [usr/share/lintian/overrides/blueman:4] N: I: blueman source: uses-deprecated-python-stdlib uu (deprecated in Python 3.11, removed in Python 3.13) [blueman/Sdp.py:3] N: N: N: In Python $deprecated, $library has been formally marked as deprecated. N: Code that imports $library will no longer work from Python $removed. N: N: Please prepare for this deprecation and migrate away from this Python N: library. N: N: See-Also: https://peps.python.org/pep-0594/#deprecated-modules N: N: Visibility: info N: Show-Always: no N: Check: languages/python/stdlib-deprecation N: N: I: blueman source: uses-deprecated-python-stdlib uu (deprecated in Python 3.11, removed in Python 3.13) [blueman/main/NetworkManager.py:3] 3. Licenses [4]: Issue philwyett@ks-windu:~/Development/builder/debian/mentoring/blueman-2.4.3$ lrc -t : Versions: recon 1.14 check 3.3.9-1 Parsing Source Tree .... Reading copyright .... Running licensecheck .... d/copyright | licensecheck GPL-3+ | FSFULLR config.rpath GPL-3+ | GPL-3 meson.build GPL-3+ | FSFAP po/Makefile.in.in 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: Good Summary... I believe blueman is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002 * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Threads: https://www.threads.net/@kathenasorg --
Attachment:
signature.asc
Description: This is a digitally signed message part