[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1077619: RFS: graphite-carbon/1.1.10-2 -- backend data caching and persistence daemon for Graphite



Control: tags -1 + moreinfo

Alexandre,

Preamble...

Thank you for taking the time to prepare this package and your contribution
to the Debian project.

The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Issue

autopkgtest [18:48:29]: test smoke: [-----------------------
nc: connect to localhost (127.0.0.1) port 2003 (tcp) failed: Connection
refused
nc: connect to localhost (127.0.0.1) port 2003 (tcp) failed: Connection
refused
autopkgtest [18:48:29]: test smoke: -----------------------]
autopkgtest [18:48:29]: test smoke:  - - - - - - - - - - results - - - - - -
- - - -
smoke                FAIL non-zero exit status 1
autopkgtest [18:48:29]: @@@@@@@@@@@@@@@@@@@@ summary
smoke                FAIL non-zero exit status 1

E: Autopkgtest run failed.

2. Lintian [3]: Issue

I: graphite-carbon source: uses-deprecated-python-stdlib distutils
(deprecated in Python 3.10, removed in Python 3.12) [setup.py:57]
N: 
N:   
N:   In Python $deprecated, $library has been formally marked as deprecated.
N:   Code that imports $library will no longer work from Python $removed.
N:   
N:   Please prepare for this deprecation and migrate away from this Python
N:   library.
N:   
N:   See-Also: https://peps.python.org/pep-0594/#deprecated-modules
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: languages/python/stdlib-deprecation

3. Licenses [4]: Issue

philwyett@ks-solo:~/Development/builder/debian/mentoring/graphite-carbon-
1.1.10$ lrc -t
: Versions: recon 1.14  check 3.3.9-1

Parsing Source Tree  ....
Reading copyright    ....
Running licensecheck ....

d/copyright     | licensecheck

Custom-AMQP-Working-Group| BSD-3-clause     lib/carbon/amqp0-8.xml
Apache-2.0      | Apache           setup.py

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice <package>.dsc]: 

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Not performed at this time

8. Upgrade [Over previous installs if any]: Not performed at this time

Summary...

I believe graphite-carbon is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.

Regards

Phil

[1] pbuilder:

  * Command: sudo pbuilder build <PACKAGE>.dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild <PACKAGE>.dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc -t
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method

-- 

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg/

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: