Control: tags -1 + moreinfo Alexandre, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue I: libjs-jush source: composer-package-without-pkg-php-tools-builddep [composer.json] N: N: The package contains a composer.json file but doesn't build-depend on N: pkg-php-tools. N: N: pkg-php-tools is the recommended tool for building PHP Composer packages. N: For more information, install it and read the included README.Composer. N: N: Visibility: info N: Show-Always: no N: Check: languages/php/pear I: libjs-jush: wrong-section-according-to-package-name web => javascript N: N: This package has a name suggesting that it belongs to a section other than N: the one it is currently categorized in. N: N: Visibility: info N: Show-Always: no N: Check: fields/section W: libjs-jush: embedded-javascript-library please use libjs-jquery-jush [usr/share/javascript/jush/jquery.jush.js] N: N: This package contains an embedded copy of JavaScript libraries that are N: now available in their own packages (for example, JQuery, Prototype, N: Mochikit or "Cropper"). Please depend on the appropriate package and N: symlink the library into the appropriate location. N: N: Please refer to Embedded code copies (Section 4.13) in the Debian Policy N: Manual for details. N: N: Visibility: warning N: Show-Always: no N: Check: languages/javascript/embedded 3. Licenses [4]: Good 4. Watch file [uscan --force-download]: N/A 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A Summary... I believe libjs-jush is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc -t * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
Attachment:
signature.asc
Description: This is a digitally signed message part