On Fri, 26 Jul 2024 18:11:37 +0200 Julius Pfrommer <julius.pfrommer@web.de> wrote: > Phil, > > Thanks for the review and the quick response. > > A new version #13 is now on mentors. > This is based on the new upstream release v1.4.3. > > 1. Typos > The mentioned typos in our code have been fixed. > The remaining typos are imported from dependencies (XML files from the IEC 62541 standard). > > 2. The standards version is now 4.7.0 > > 3. We now use debhelper-compat (= 13) and have removed the compats file > > Thus all points from your review have been considered. > Thank you for taking another look. > > -- > Regards, Julius > > Hi Juilius, Great work. The effort you have made shows in the package. One little thing. There is still one spelling error. I: libopen62541-1.4: spelling-error-in-binary explicity explicitly [usr/lib/x86_64-linux-gnu/libopen62541.so.1.4.3] N: N: Lintian found a spelling error in the given binary. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext or a similar tool, please fix the error in the translations as N: well as the English text to avoid making the translations fuzzy. With N: gettext, for example, this means you should also fix the spelling mistake N: in the corresponding msgids in the *.po files. N: N: You can often find the word in the source code by running: N: N: grep -rw <word> <source-tree> N: N: This tag may produce false positives for words that contain non-ASCII N: characters due to limitations in strings. N: N: Visibility: info N: Show-Always: no N: Check: binaries/spelling If we could fix this then we would be ready to mark it ready for a DD to look at. Regards Phil -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
Attachment:
signature.asc
Description: This is a digitally signed message part