Bug#1066870: RFS: libudis86/0+20221013-1 [ITP] -- Disassembler for x86 and x86-64 class ISA

[Alan M Varghese <alan@digistorm.in>]

Control: tags -1 - moreinfo

Hello Phil,

Thank you for reviewing my package.

I have uploaded a new version to mentors with the following fixes:
1. Removed '${shlibs:Depends}' from -doc and -dev packages.
2. Refactored d/changelog and moved additional information to d/README.Debian
3. Updated to new Standards-Version in d/control

> W: udcli: groff-message troff:<standard input>:100: warning: cannot select font
> 'C' [usr/share/man/man1/udcli.1.gz:3]
The lintian warning "cannot select font 'c'", is because of an issue with 'pandoc':
https://github.com/jgm/pandoc/issues/9020

I use pandoc to generate the man page for the CLI tool 'udcli', built from this
package. As far as I understand it, this warning is benign and should fix itself
when we have a newer version of pandoc in Debian.

PS: I have made some changes to the -doc package, which now also includes the
documentation included in the upstream package.

Thanks & Regards,
Alan

On 6/19/24 03:48, Phil Wyett wrote:
> Control: tags -1 + moreinfo
>
> Hi Alan,
>
> Thanks for taking time to create this package and your contribution to Debian.
>
> Review...
>
> 1. Build: OK
>
> 2. Lintian: WARNINGS
>
> W: udcli: groff-message troff:<standard input>:100: warning: cannot select font
> 'C' [usr/share/man/man1/udcli.1.gz:3]
> N:
> N:   A manual page provoked warnings or errors from the man program. Here are
> N:   some common ones:
> N:
> N:   "cannot adjust" or "can't break" are issues with paragraph filling. They
> N:   are usually related to long lines. Justifying text on the left hand side
> N:   can help with adjustments. Hyphenation can help with breaks.
> N:
> N:   For more information, please see "Manipulating Filling and Adjusting" and
> N:   "Manipulating Hyphenation" in the Groff manual (see info groff).
> N:
> N:   "can't find numbered character" usually means that the input was in a
> N:   national legacy encoding. The warning means that some characters were
> N:   dropped. Please use escapes such as \[:a] as described on the groff_char
> N:   manual page.
> N:
> N:   Other common warnings are formatting typos. String arguments to .IP
> N:   require quotes. Usually, some text is lost or mangled. See the groff_man
> N:   (or groff_mdoc if using mdoc) manual page for details on macros.
> N:
> N:   The check for manual pages uses the --warnings option to man to catch
> N:   common problems, like a . or a ' at the beginning of a line as literal
> N:   text. They are interpreted as Groff commands. Just reformat the paragraph
> N:   so the characters are not at the beginning of a line. You can also add a
> N:   zero-width space (\&) in front of them.
> N:
> N:   Aside from overrides, warnings can be disabled with the .warn directive.
> N:   Please see "Debugging" in the Groff manual.
> N:
> N:   You can see the warnings yourself by running the command used by Lintian:
> N:
> N:       LC_ALL=C.UTF-8 MANROFFSEQ='' MANWIDTH=80 \
> N:           man --warnings -E UTF-8 -l -Tutf8 -Z <file> >/dev/null
> N:
> N:   Please refer to the groff_man(7) manual page and the groff_mdoc(7) manual
> N:   page for details.
> N:
> N:   Visibility: warning
> N:   Show-Always: no
> N:   Check: documentation/manual
> N:   Renamed from: manpage-has-errors-from-man
> N:
> N:
> W: udcli: groff-message troff:<standard input>:5: warning: cannot select font
> 'CB' [usr/share/man/man1/udcli.1.gz:1]
> N:
> W: udcli: groff-message troff:<standard input>:92: warning: cannot select font
> 'C' [usr/share/man/man1/udcli.1.gz:2]
>
> 3. Licenses check: OK
>
> 4. Build Twice (sudo pbuilder build --twice <package>.dsc): OK
>
> 5. Install (No previous installs): OK
>
> 6. Upgrade (Over previous installs if any): N/A
>
> Additional...
>
> A.
>
> dpkg-gencontrol: warning: Depends field of package libudis86-doc: substitution
> variable ${shlibs:Depends} used, but is not defined
> dpkg-gencontrol: warning: Depends field of package libudis86-dev: substitution
> variable ${shlibs:Depends} used, but is not defined
>
> Remove '${shlibs:Depends}' from each of the above packages and the build time
> warnings will be eliminated.
>
> B. 'debian/changelog'
>
> For a new package it should just have the first entry. The entries below I would
> advise be put in a 'debian/README.debian' file. I would also elaborate on the
> last entry regarding manpage generation.
>
> * This packaging is based on the fork
> https://github.com/canihavesomecoffee/udis86 which includes "fixes and
> additions" from other forks.
> * The latest upstream release is v1.7.2 made on Sep 2, 2013. This build is     h
> owever, based on the latest commit #5336633, made on Oct 13, 2022
> * Created a man page for udcli based on information from '--help' and     additi
> onal information from the project's README.
>
> C. 'debian/control'
>
> While not a warning as yet. Please update 'Standards-Version' to latest
> 4.7.0[1].
>
> [1] https://www.debian.org/doc/debian-policy/
>
> Please address the issues raised and remove the 'moreinfo' tag when doing
> next/fixed upload.
>
> Regards
>
> Phil