Control: tags -1 + moreinfo Hi, Review of package. 1. 'debian/copyright' Lintian: E: hexwalk: copyright-contains-dh_make-todo-boilerplate N: N: The string "Please also look if..." appears in the copyright file, which N: indicates that you either didn't check the whole source to find additional N: copyright/license, or that you didn't remove that paragraph after having N: done so. N: N: Please refer to Copyright information (Section 12.5) in the Debian Policy N: Manual for details. N: N: Visibility: error N: Show-Always: no N: Check: debian/copyright N: Boilerplate text at bottom of file needs to be removed. 2. 'debian/control' Lintian: E: hexwalk: description-starts-with-package-name N: N: The first line of the "Description:" should not start with the package N: name. For example, the package foo should not have a description like N: this: "foo is a program that...". N: N: Please refer to The single line synopsis (Section 3.4.1) in the Debian N: Policy Manual for details. N: N: Visibility: error N: Show-Always: no N: Check: fields/description N: Could be changed to: A hexadecimal analyzer, editor and viewer 3. 'debian/changelog' Lintian: E: hexwalk: possible-missing-colon-in-closes Closes #1063579 [usr/share/doc/hexwalk/changelog.Debian.gz:1] N: N: To close a bug in the Debian changelog, the word "closes" must be followed N: by a colon. This entry looked like it was intended to close a bug, but N: there's no colon after "closes". N: N: Please refer to Debian changelog: debian/changelog (Section 4.4) in the N: Debian Policy Manual for details. N: N: Visibility: error N: Show-Always: no N: Check: debian/changelog N: When closing a bug in changelog 'Closes' must end with ':'. Your changelog can be fixed and reformatted to the below. hexwalk (1.7.1-1) unstable; urgency=medium * Initial release (Closes: #1063579) -- Carmix <carmixdev@gmail.com> Sun, 3 Mar 2024 13:56:50 +0100 4. 'debian/copyright' Lintian: W: hexwalk: copyright-has-url-from-dh_make-boilerplate N: N: There is "url://example.com" in your copyright file. This was most likely N: a remnant from the dh_make template. N: N: Make sure you include the real location where you obtained the upstream N: sources (if any). N: N: Please refer to Copyright information (Section 12.5) in the Debian Policy N: Manual for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/copyright N: Line is 'Source: <url://example.com>' and needs to have correct value inserted. 5. 'debian/control' Lintian: W: hexwalk: description-starts-with-leading-spaces line 1 N: N: The package's extended "Description:" paragraph starts with more than one N: leading space. Usually, leading spaces are used to switch "verbatim N: display" on (i.e., lines are not wrapped) so this might be a bug in the N: package. N: N: Visibility: warning N: Show-Always: no N: Check: fields/description N: Line 16 of 'debian/control', the long description should have no more than one leading space. 6. 'debian/control' Lintian: W: hexwalk: extended-description-line-too-long line 1 N: N: One or more lines in the extended part of the "Description:" field have N: been found to contain more than 80 characters. For the benefit of users of N: 80x25 terminals, it is recommended that the lines do not exceed 80 N: characters. N: N: Please refer to The single line synopsis (Section 3.4.1) in the Debian N: Policy Manual for details. N: N: Visibility: warning N: Show-Always: no N: Check: fields/description N: Line one and three of long description is too long. Keep line length to 80 characters or less for terminal users. 7. 'debian/rules' Add hardening features. https://wiki.debian.org/Hardening Please address the issues raised and remove the moreinfo tag when doing next/fixed upload. Regards Phil -- Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Attachment:
signature.asc
Description: This is a digitally signed message part