Hi Adam, Thanks for all the feedback! I've addressed them all and updated to 1.8.5 which has been released in the meantime. Added comments inline - and the additional question at the end. https://mentors.debian.net/package/damo/ https://salsa.debian.org/python-team/packages/damo/-/tree/44d7ecd2bf2af277e2b93be82c32ffcb242f5d17 On Mon, Jun 12, 2023 at 05:15:24PM +0200, Adam Borowski wrote: > On Tue, Jun 06, 2023 at 09:45:25PM -0500, Michel Alexandre Salim wrote: > > Hi! > The commands you run for % targets will fail badly if ran in parallel, and > that's the default these days. Please run that only once, eg from > override_dh_auto_configure (as that's a target that's run early). > Fixed, thanks > Other nice to have bits: > * the description doesn't say what DAMON is, even "Data Access Monitoring > Operator" doesn't shed much light Added description, thank you! > * a command-line tool really should have a man page Added a manpage using help2man and checked in the generator script One question: is it alright to mark the architecture here as "all"? The code itself is pure Python, but it depends on functionality of the Linux kernel. `linux-all` is not a valid target, and if I mark it as `linux-any` it will... cause buildd to unnecessarily build this on each architecture, right? Best regards, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
Attachment:
signature.asc
Description: PGP signature