Hi Lorenzo, Thank you for the help with reviewing :) Hi Alexandru, Reply follows inline with two hints. Lorenzo <plorenzo@disroot.org> writes: > On Thu, 01 Jun 2023 12:05:51 +0000 > Alexandru Mihail <alexandru_mihail@protonmail.ch> wrote: > >> I've uploaded again to mentors, the (now gone) lintian warning >> complained about missing the SystemD service for the package. I've >> added one from scratch and upon initial testing it performs OK. Wonderful :) By the way, do you know if the forking service type is needed for mini-httpd? This page notes when that type is required: https://wiki.debian.org/systemd/Services >> I modified debian/rules to take the service into consideration though >> this raises some concerns for non-systemd Debian installations. I >> assume further modifications are required to intelligently enable or >> ignore the service (use old init.d mechanism). Thank you for considering the implications of your changes, especially at this phase of the freeze when we all need to be really careful about any changes. > (looking at your rules file) > override_dh_installinit: > dh_installinit --no-stop-on-upgrade --no-start --name=mini-httpd > > override_dh_installsystemd: > dh_installsystemd --name=mini-httpd > > if the '--no-stop-on-upgrade --no-start' is to avoid a conflict between > the systemd service and the init.d file, you don't need that: debhelper > generated scripts should do the right thing. > If you look at generated maintscripts One way to do this is 'dpkg-deb -R [aka: --raw-extract] archive directory', then inspect the DEBIAN dir. > you see that systemctl calls are guarded by a test for > /run/systemd/system (it imply that systemd is the running init); the > equivalent code for sysvinit (invoke.rc.d) is not guarded but that's > ok since other inits are supposed to mask initscripts and systemd > already does that. Thanks again for your analysis and explanation Lorenzo! Regards, Nicholas
Attachment:
signature.asc
Description: PGP signature