Control: close -1
On Sat, 2023-04-15 at 15:59 +0200, Michael Ablassmeier wrote:
> I am looking for a sponsor for my package "trurl":
What is the status of getting your new OpenPGP key accepted? Some links
related to that below, if you are having trouble with keysigning then
key endorsements might be another option.
https://keyring.debian.org/
https://keyring.debian.org/replacing_keys.html
https://wiki.debian.org/Keysigning/Offers
https://lists.debian.org/msgid-search/20200913071104.qcx76k25q5dpt2cn@enricozini.org
https://lists.debian.org/msgid-search/20201108205109.6nzboemjkr5ik2ck@enricozini.org
Package looks good, uploaded it to NEW.
You might want to add some autopkgtests, I think this would require
patching test.pl to use PATH instead of ./ and then patching Makefile
to set PATH to include the build directory (be sure to send those to
upstream). Then you will be able to run the tests against the installed
binary /usr/bin/trurl instead of the build dir.
https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst
https://wiki.debian.org/ContinuousIntegration
https://ci.debian.net/doc/
Tools' complaints that might be worth fixing upstream or in Debian:
$ lintian --info --show-overrides --color auto --display-info --display-experimental --pedantic
I: trurl source: debian-watch-file-is-missing
I: trurl: hardening-no-bindnow [usr/bin/trurl]
I: trurl: typo-in-manual-page occurances occurrences [usr/share/man/man1/trurl.1.gz:39]
X: trurl source: upstream-metadata-file-is-missing
$ find . -type f -exec anorack {} +
./checksrc.pl:851: a extended -> an extended /Ekst'EndI2d/
$ codespell --quiet-level=3 .
./trurl.1:39: occurances ==> occurrences
./trurl.c:859: inbetween ==> between, in between
./RELEASE-NOTES:20: messsage ==> message
$ find . -type f -exec spellintian {} +
./trurl.1: occurances -> occurrences
# wrap-and-sort makes VCS diffs of package info easier to read
$ wrap-and-sort --short-indent --wrap-always --sort-binary-packages --trailing-comma --dry-run
--- Dry run, these files would be modified ---
debian/control
$ find . -type f -iname '*.[1-9]' -exec mandoc -T lint -W warning {} +
mandoc: ./trurl.1:5:13: WARNING: cannot parse date, using it verbatim: TH 3 Apr 2023
$ find .. -maxdepth 1 -type f -iwholename '../*.build' -exec blhc --all {} +
CFLAGS missing (-fPIE): cc -g -O2 -ffile-prefix-map=/home/pabs/devel/debian/mentors/trurl-0.4=. -fstack-protector-strong -Wformat -Werror=format-security -W -Wall -pedantic -g -Wdate-time -D_FORTIFY_SOURCE=2 -c -o trurl.o trurl.c
LDFLAGS missing (-fPIE -pie -Wl,-z,now): cc -Wl,-z,relro trurl.o -lcurl -o trurl
$ find . -type f -iwholename './debian/*/bin/*' -exec hardening-check --quiet {} +
./debian/trurl/usr/bin/trurl:
Immediate binding: no, not found!
Control flow integrity: no, not found!
$ find . -type f -iname '*.yml' -exec yamllint --config-data relaxed {} +
./.github/workflows/makefile.yml
21:81 warning line too long (122 > 80 characters) (line-length)
30:81 warning line too long (86 > 80 characters) (line-length)
48:7 warning wrong indentation: expected 4 but found 6 (indentation)
$ perlcritic --noprofile --verbose '%f:%l:%c: %m. %e. Near `%r` (Severity: %s)\n' --gentle .
checksrc.pl:100:5: Bareword file handle opened. See pages 202,204 of PBP. Near `open(W, "<$dir/checksrc.skip") or return;` (Severity: 5)
checksrc.pl:100:5: Two-argument "open" used. See page 207 of PBP. Near `open(W, "<$dir/checksrc.skip") or return;` (Severity: 5)
checksrc.pl:382:5: Bareword file handle opened. See pages 202,204 of PBP. Near `open(R, "<$file") || die "failed to open $file";` (Severity: 5)
checksrc.pl:382:5: Two-argument "open" used. See page 207 of PBP. Near `open(R, "<$file") || die "failed to open $file";` (Severity: 5)
$ cppcheck -j1 --quiet --enable=all .
trurl.c:517:9: style: The scope of the variable 'i' can be reduced. [variableScope]
int i;
^
trurl.c:788:7: style: The scope of the variable 'rc' can be reduced. [variableScope]
int rc;
^
trurl.c:790:9: style: The scope of the variable 'oldnq' can be reduced. [variableScope]
char *oldnq;
^
trurl.c:516:11: style: Local variable 'set' shadows outer function [shadowFunction]
char *set = node->data;
^
trurl.c:509:13: note: Shadowed declaration
static void set(CURLU *uh,
^
trurl.c:516:11: note: Shadow variable
char *set = node->data;
^
trurl.c:622:9: style: Local variable 'i' shadows outer variable [shadowVariable]
int i;
^
trurl.c:606:7: note: Shadowed declaration
int i;
^
trurl.c:622:9: note: Shadow variable
int i;
^
trurl.c:187:17: style: struct member 'option::output' is never used. [unusedStructMember]
unsigned char output;
^
--
bye,
pabs
https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part