[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1031146: RFS: lighttpd/1.4.69-1 [NMU] -- light, fast, functional web server



Hello Glenn,

El 12/02/23 a las 08:54, Glenn Strauss escribió:
> > Since you are listed in Uploaders:, this shouldn't be a NMU. I don't
> > understand why lintian doesn't complain about this in this job:
> > https://salsa.debian.org/debian/lighttpd/-/jobs/3931309
> > but don't have the time to investigate that right now.
> > 
> > Please, fix the changelog.
> 
> changelog updated.  Thanks for your guidance.
> Cheers, Glenn
> 

Sorry I was unable to give you more feedback the first time. So I am
iterating. ENOTIME…

Here you have some comments regarding two files:

1. d/changelog:

lighttpd (1.4.69-1) unstable; urgency=medium

  [ Glenn Strauss ]

Since you are the only one doing changes in this release, no need to
tell that twice. You can remove the line above.

  * New upstream version 1.4.69
  * (changes for 1.4.68; not released in Debian)

I am afraid I cannot parse that entry. What are the changes related to
1.4.68?

  * Remove deprecated lighttpd modules.
  * Skip installing modules now built into lighttpd.
  * Add to not-installed mods now built into lighttpd.

Is it worth to list those modules?
Is there any impact for the uses to they should be warned via e.g.
debian/NEWS too?

  * Declare compliance with policy 4.6.2 - no changes needed.
  * lighttpd.init reopen-logs only if lighttpd is currently running.
  * New upstream version 1.4.68

I don't think the line above is needed. You are doing a release for
1.4.69.

    $ git branch --track upstream     origin/upstream
    $ git branch --track pristine-tar origin/pristine-tar
    $ release=1.4.68
    $ cd ..
    $ wget https://download.lighttpd.net/lighttpd/releases-1.4.x/lighttpd-$release.tar.xz
    $ wget https://download.lighttpd.net/lighttpd/releases-1.4.x/lighttpd-$release.tar.xz.asc

(Just in case, you can use uscan for that)

    $ cd -
    $ git fetch origin
    $ git checkout pristine-tar
    $ git pull --rebase
    $ git checkout master
    $ gbp import-orig --uscan -u $release
    # - adds commits to 'pristine-tar' and 'upstream' branches
    # - tags 'upstream' branch upstream/$release
    # - merges upstream/$release tag into master branch
    $ git push origin master pristine-tar upstream/$release

Neither I wouldn't place these instructions in d/changelog.

 -- Glenn Strauss <gstrauss@gluelogic.com>  Fri, 10 Feb 2023 22:34:51 -0500


2. d/lighttpd.NEWS:

As lintian complains, this entry relates a release not known by debian:

lighttpd (1.4.67-2) experimental; urgency=medium

Do you think NEWS could be updated?

Cheers,

 -- Santiago

Attachment: signature.asc
Description: PGP signature


Reply to: