Bug#1025959: Feedback regarding RFS: davmail/6.0.1.3390-2
Hi,
> > > * Review / improve the `prepare-service`
> >
> > This history behind this script is detailed in:
> >
> > startup script that copies keystoreFile to StateDirectory (Closes: #968236)
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968236
>
> Seen the "adduser _davmail" advice.
> And seeing that "adduser _davmail" in debian/davmail-server.postinst
> (I didn't see that post install script yesterday)
>
> > The point is to make available private keys to the daemon. Do you think I need
> > to add comments to the script to explain the purpose?
>
> Yes please, elaborate purpose AND elaborate the
>
> if keystore is a file then create keystore file
https://salsa.debian.org/debian/davmail/-/commit/be580785dbd6a4232a2fe408c144ccfc80f93017
> What about doing this development in a git branch?
https://salsa.debian.org/debian/davmail/-/tree/unstable-wip
Many thanks for your review,
Alexandre
Reply to: